add coupon code to totals model

[SilinMykola]

Description (*)

I changed \Magento\Sales\Block\Order\Totals class to add Coupon Code to order.total block

Fixed Issues (if relevant)

1. Fixes Magento 2.3.5-p1 - Discount Description, Coupon Codes on Invoices Broken #28432

Manual testing scenarios (*)

1. Create new Cart Price Rule with long description and coupone code.
2. Create order on storefront.
3. Check coupon code in order view, invoice view, order print, invoice print

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @SilinMykola. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[SilinMykola]

@magento run all tests

[atwixfirster]

@magento run all tests

[m2-assistant]

Hi @SilinMykola, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[SilinMykola]

@magento run all tests

[SilinMykola]

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

[andrewbess]

@magento run Integration Tests

[andrewbess]

Hello @SilinMykola
Thank you for your contribution;
Please don't forget to keep an empty string after imports

Suggested change

	use Magento\Sales\Model\Order\Invoice;
	use Magento\Sales\Model\Order\Invoice;

[SilinMykola]

Hello @andrewbess
Thanks for your reviewing, I fixed your remark.

[coderimus]

Hi @SilinMykola
Thank you for your work. Please, check my comment below.

[coderimus]

As I see from the suggested solution, the coupon code description will not be shown anymore, but it was expected to be shown. In other words, this solution replaces coupon code description with its code. It is not correct from the user experience.
It is also impossible to change the $discountLabel text because this class is an @api (BIC change).

I can suggest to implement something like this:

            $discountLabel = $this->getSource()->getDiscountDescription()
                ? __('Discount (%1)', $source->getDiscountDescription())
                : __('Discount (%1)', $source->getCouponCode());

With this, we will have a coupon code or description in the Discount line. And not the BIC change.

[coderimus]

Hi @SilinMykola,
Do you need assistance with this PR? :)

[SilinMykola]

Hi @coderimus, yes, I need help with this issue. I think about where I should create the settings in admin panel to choose what to show in "totals" (coupon description, coupon code or both) and how to split description in a few strings.
If you have some ideas please tell and I continue with this issue.

[coderimus]

Hi @sivaschenko
Can you please check this PR? We have two ways: add a simple adjustment to the code to fix the reported error or add a new setting for such a purpose. What is the right solution from your perspective?