Skip to content

[PHPDOC] Fix functions orderComment in Magento\Sales\Model\Order #39572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimitriBouteille wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

[PHPDOC] Fix functions orderComment in Magento\Sales\Model\Order #39572

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d56049
Fix bad phpdoc for function orderComment in Magento\Sales\Model\Order
Jan 28, 2025
9e8b873
PHPDoc: Use \Stringable instead of \Magento\Framework\Phrase in Magen…
Jan 31, 2025
5493815
Merge branch '2.4-develop' into phpdoc/sales-order-history
dimitriBouteille Feb 4, 2025
ddde5d3
Merge branch '2.4-develop' into phpdoc/sales-order-history
dimitriBouteille Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/code/Magento/Sales/Model/Order.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,7 +1184,7 @@ public function getStatusLabel()
* Add status change information to history
*
* @param string $status
* @param string $comment
* @param string|\Stringable $comment
* @param bool $isCustomerNotified
* @return $this
*/
Expand All @@ -1199,7 +1199,7 @@ public function addStatusToHistory($status, $comment = '', $isCustomerNotified =
*
* Different or default status may be specified.
*
* @param string $comment
* @param string|\Stringable $comment
* @param bool|string $status
* @return OrderStatusHistoryInterface
* @deprecated 101.0.5
Expand All @@ -1215,7 +1215,7 @@ public function addStatusHistoryComment($comment, $status = false)
*
* Different or default status may be specified.
*
* @param string $comment
* @param string|\Stringable $comment
* @param bool|string $status
* @param bool $isVisibleOnFront
* @return OrderStatusHistoryInterface
Expand Down Expand Up @@ -1346,7 +1346,7 @@ public function isFraudDetected()
/**
* Prepare order totals to cancellation
*
* @param string $comment
* @param string|\Stringable $comment
* @param bool $graceful
* @return $this
* @throws LocalizedException
Expand Down