Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#39604: Fixed error with script (404) #39677

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

magento/magento2#39604: Fixed error with script (404) #39677

wants to merge 6 commits into from
+9 −9

Conversation

BeggiNN
Copy link
Contributor

@BeggiNN BeggiNN commented Feb 28, 2025 •
edited
Loading

  • Fixed issue for error: Script error for catalogAddToCart

Description (*)

Magento version
2.4.x
Anything else that would help a developer reproduce the bug

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Error: Script error for "Magento_Catalog/js/validate-product" for admin content pagebuilder with products load #39604

Manual testing scenarios (*)

  1. Open admin menu -> content -> pages -> edit or create new page -> edit with pagebuilder -> add row/column -> add products 2. from sidebar and choose your conditions
  2. save
  3. reopen with pagebuilder
  4. console does not have errors

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@BeggiNN
magento#39604: Fixed error with script (404)
c6b4e4b 
- Fixed issue for error: Script error for `catalogAddToCart`
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Feb 28, 2025

Hi @BeggiNN. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Feb 28, 2025
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Feb 28, 2025

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 28, 2025
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Feb 28, 2025

@magento run all tests

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 4, 2025

@magento run Unit Tests, WebAPI Tests, Integration Tests, Functional Tests EE, Functional Tests B2B, Database Compare

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 5, 2025

@magento run Integration Tests, Functional Tests EE, Functional Tests B2B

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 6, 2025

@magento run Functional Tests EE, Functional Tests B2B

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 11, 2025

@magento run Functional Tests B2B

1 similar comment
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 12, 2025

@magento run Functional Tests B2B

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Mar 13, 2025
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 18, 2025

@magento run Functional Tests B2B

1 similar comment
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 25, 2025

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @BeggiNN,

The changes looks good to me. Below some changes suggested, please do the needful.

Thanks

@engcom-Hotel
Copy link
Contributor

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees
No one assigned
Labels
Partner: Perspective partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Ready for Testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Script error for "Magento_Catalog/js/validate-product" for admin content pagebuilder with products load
5 participants
@BeggiNN @engcom-Hotel @engcom-Bravo @m2-github-services @Priyakshic