Skip to content

improve error handling SchemaBuilder #39799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

Genaker
Copy link

@Genaker Genaker commented Apr 10, 2025

Extending error context :
Previousle:
Warning: Undefined array key "type" in /var/www/html/magento/vendor/magento/framework/Setup/Declaration/Schema/Db/SchemaBuilder.php on line 91

Few Moments later:
Warning: Undefined array key "type" in /var/www/html/magento/vendor/magento/framework/Setup/Declaration/Schema/Db/SchemaBuilder.php on line 91 Error processing table catalog_eav_attribute column is_used_in_autocomplete

image

Help undersend the issue without heavy debugging!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] improve error handling SchemaBuilder #39816: improve error handling SchemaBuilder

Extending error context : 
Previous: 
```Warning: Undefined array key "type" in /var/www/html/magento/vendor/magento/framework/Setup/Declaration/Schema/Db/SchemaBuilder.php on line 91```

Now: 
```Warning: Undefined array key "type" in /var/www/html/magento/vendor/magento/framework/Setup/Declaration/Schema/Db/SchemaBuilder.php on line 91
Error processing table catalog_eav_attribute column is_used_in_autocomplete```

Help undersend the issue without heavy debugging!
Copy link

m2-assistant bot commented Apr 10, 2025

Hi @Genaker. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@orkuncv
Copy link

orkuncv commented Apr 15, 2025

For tables that are defined without columns and marked with disabled="true", like the example below:
<table name="amasty_stockstatus_quantityranges" resource="default" engine="innodb" comment="amasty_stockstatus_quantityranges" disabled="true"/>

You could consider adding the following check in your processing logic, e.g., around line 89:
if (!isset($tableColumns['column'])) { error_log("Missing 'column' key for table '{$keyTable}': " . json_encode($tableColumns)); continue; }

@Genaker
Copy link
Author

Genaker commented Apr 15, 2025

For tables that are defined without columns and marked with disabled="true", like the example below:

<table name="amasty_stockstatus_quantityranges" resource="default" engine="innodb" comment="amasty_stockstatus_quantityranges" disabled="true"/>

You could consider adding the following check in your processing logic, e.g., around line 89:

`if (!isset($tableColumns['column'])) {

error_log("Missing 'column' key for table '{$keyTable}': " . json_encode($tableColumns));

continue;

}`

is it for me? Who should add?

@engcom-Hotel
Copy link
Contributor

@magento create issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

[Issue] improve error handling SchemaBuilder
3 participants