PHP error unoticed issue fixed

[Sathakathulla-S]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes [\Magento\ConfigurableProduct\Model\Product\Type\Configurable] PHP error unoticed #39641

Manual testing scenarios (*)

1. My phpstorm detected an error in a Preference I had to declare copying the entire
   \Magento\ConfigurableProduct\Model\Product\Type\Configurable.
2. The following function has an issue because $product variable is used by the loop as looping element erasing the given variable.
3. Issue fixed now.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Sathakathulla-S. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[Sathakathulla-S]

@magento run all tests

[hostep]

Thanks @Sathakathulla-S, but it looks like we already have the same fix send in a few months ago: #39642

[bhennesAdv]

Hello,

@Sathakathulla-S I kindly invite you to check that :

• A PR was already linked to the related Issue.
• A comment was already present on the related issue mentionning that a PR is waiting

Hello,

I made a PR for the change but I don't know on which branch do you want me to create the PR to ?

For testing, the same, I did not invest time in creating automatic/manual testing for a variable name change in a deprecated function. Let me know if you need more.

Regards,
Baptiste

• You copied the exact code of the existing PR in your PR.
• You did exactly the same for your PR Newsletter subscribe enabled switch not working issue fixed #39807 which is an exact copy of Add store level to config read #39752

Assuming that this is not on purpose, I think that you need to pay more attention to existing PR related to Issues.
This is just adding review work to maintainers for nothing.
Any administrator can close this PR and #39807 ?

Kind Regards,
Baptiste

[Sathakathulla-S]

Hello @bhennesAdv ,

Thanks for the feedback.

I understand the concern. That was not intentional, Before picking up the issue, I verified that the problem was still reproducible on my end, and I proceeded based on that observation. I must have missed the already existing PR and the related comments, and I’ll make sure to double-check more thoroughly next time before starting work on an issue.

And I am not copying anyone's work; I only created the pull requests if they were reproduced and if I fixed them myself. If you have any doubt, Please check this PR #39795 .

Please feel free to close the PRs #39811 and #39807, and thanks again for pointing this out.

Kind Regards,
Sathakathulla S

[ihor-sviziev]

Hi @Sathakathulla-S,
I'm closing this pull request as a duplicate of #39642