Skip to content

Update definition.map.xml #39979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Update definition.map.xml #39979

wants to merge 2 commits into from

Conversation

LucScu
Copy link

@LucScu LucScu commented Jun 10, 2025

fix isMultipleFiles option for fileUploader component

Description (*)

isMultipleFiles option settings doesn't work for fileUploader element in the form ui_component xml.
Even if you add true it is not read and it remains false as default.

Manual testing scenarios (*)

  1. create a field with fileUploader element in a form ui component
  2. add the true
  3. visit the page and you could add multiple files

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

fix isMultipleFiles option for fileUploader component
Copy link

m2-assistant bot commented Jun 10, 2025

Hi @LucScu. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@LucScu
Copy link
Author

LucScu commented Jun 11, 2025

@magento run all tests

@LucScu
Copy link
Author

LucScu commented Jun 11, 2025

@magento run all tests

@LucScu
Copy link
Author

LucScu commented Jun 12, 2025

@ihor-sviziev could you approve this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant