Expose PayPal Express availability in GraphQL storeConfig (#39165) - #41217
Open
lbajsarowicz wants to merge 11 commits into
Open
Expose PayPal Express availability in GraphQL storeConfig (#39165)#41217lbajsarowicz wants to merge 11 commits into
lbajsarowicz wants to merge 11 commits into
Conversation
…5-paypal-express-store-config # Conflicts: # app/code/Magento/PaypalGraphQl/etc/graphql/di.xml
…st (magento#39165) Continues magento#39163 by @dimitriBouteille. Asserts paypal_express_active and paypal_express_visible_on_cart follow the payment/paypal_express/active and payment/paypal_express/visible_on_cart config values.
Contributor
Author
|
@magento run all tests |
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Continues #39163 by @dimitriBouteille, which has been conflicting with
2.4-developsince 2025. This PR carries the original commits and authorship, merged with the current base.StoreConfigexposespayment_payflowpro_cc_vault_activefor the PayPal family but nothing for PayPal Express, so a headless storefront cannot tell whether the method is enabled or whether the Express button should be shown on the cart page. Both values are plain config paths,payment/paypal_express/activeandpayment/paypal_express/visible_on_cart, and are exposed here through the existingextendedConfigDatamechanism ofStoreConfigDataProvider, asBooleanfields.Changes on top of the original PR:
2.4-develop, conflict indi.xmlresolvedStoreConfigfields (the original had a typo in one of them)Magento\GraphQl\Paypal\StoreConfigTestasserting both fields follow the configured valuesThe fields return the raw configuration, the same way
payment_payflowpro_cc_vault_activeand thePaymentGraphQlfields do. Whether the Express button actually renders on the storefront also depends onMagento\Paypal\Helper\Shortcut\Validator(method availability), which is not replicated here.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
{ storeConfig { paypal_express_active paypal_express_visible_on_cart } }to/graphql: both returntrue.paypal_express_visible_on_cartreturnsfalse.Questions or comments
Gates run locally: PHPCS, PHPStan and the Static Tests
LiveCodeTeston the changed files are clean. The API-functional test needs the WebAPI build.The Semantic Version Checker will report the two added
StoreConfigfields as an additive schema change.Contribution checklist (*)