Skip to content

Commit

Permalink
refactor: Set emptyHostnameLabel var inside app
Browse files Browse the repository at this point in the history
Signed-off-by: Mahendra Paipuri <[email protected]>
  • Loading branch information
mahendrapaipuri committed Dec 29, 2023
1 parent 91260d8 commit ff037cb
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions pkg/collector/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ var BatchJobExporterApp = *kingpin.New(
)

// Empty hostname flag (Used only for testing)
var emptyHostnameLabel = BatchJobExporterApp.Flag(
"collector.empty.hostname.label",
"Use empty hostname in labels. Only for testing. (default is disabled)",
).Hidden().Default("false").Bool()
var emptyHostnameLabel *bool

// Create a new BatchJobExporter struct
func NewBatchJobExporter() (*BatchJobExporter, error) {
Expand Down Expand Up @@ -97,6 +94,12 @@ func (b *BatchJobExporter) Main() {
toolkitFlags = kingpinflag.AddFlags(&b.App, ":9010")
)

// This is hidden flag only used for e2e testing
emptyHostnameLabel = b.App.Flag(
"collector.empty.hostname.label",
"Use empty hostname in labels. Only for testing. (default is disabled)",
).Hidden().Default("false").Bool()

promlogConfig := &promlog.Config{}
flag.AddFlags(&b.App, promlogConfig)
b.App.Version(version.Print(b.appName))
Expand Down

0 comments on commit ff037cb

Please sign in to comment.