-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to set custom TTL values for custom DNS records #2043
base: main
Are you sure you want to change the base?
Conversation
I did not know I needed this until i reviewed (but did not test) this PR. Nice work. 30 seconds seems a sane lower bound however is it perhaps unnecessary. Would a simple warning text be as powerful and leave operators free to deploy one second (ephemeral) DNS records |
The rationale is to save users from themselves. A TTL of 1 second is weird in the sense that should the resolver take a little longer to respond, by the time the answer is returned it already expired. Plus, some DNS resolvers will likely not honor such low TTL values anyway. On the other hand, are there use cases for 1-second-TTL use cases where a 30 second TTL wouldn't be just as fine? |
This should be good to go and to be merged :)
|
@JoshData feel free to take a look :) |
Boy I love open source. I was considering moving some domains to use mail-in-a-box for DNS, and tonight while testing the functionality realized the lack of TTL control was a dealbreaker. So no can do unless this gets addressed. Traditionally TTL's tend to bottom out around 5 seconds, which is essentially "this changes virtually every request". I could see a use for that if updating a DNS record by API to direct traffic to the appropriate backend. Most people doing this kind of stuff are setting up their own DNS when you've got this kind of scale, but I wouldn't consider it useless. The API in mail-in-a-box is surprisingly good. |
Easily possible to merge this into v60.1. Tested (short time) and works fine. |
This commit was cherry-picked from a fork of mine, it might be useful for some folks - specifically those who are relying on Dynamic DNS where the TTL of 1 day might be inappropriate.
From ddavness/power-mailinabox#28: