Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph constructor dir #275

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Graph constructor dir #275

merged 3 commits into from
Jan 22, 2025

Conversation

tcasstevens
Copy link
Collaborator

Description

New HaplotypeGraph constructor that takes a directory input

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated relevant documentation

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.

New HaplotypeGraph constructor that takes a directory input

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (5a962a2) to head (2edbeea).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...tlin/net/maizegenetics/phgv2/api/HaplotypeGraph.kt 60.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   80.87%   80.84%   -0.03%     
==========================================
  Files          95       95              
  Lines        7175     7185      +10     
  Branches     1198     1202       +4     
==========================================
+ Hits         5803     5809       +6     
- Misses        911      912       +1     
- Partials      461      464       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcasstevens tcasstevens merged commit 1ee20bf into main Jan 22, 2025
2 of 4 checks passed
@tcasstevens tcasstevens deleted the graph-constructor-dir branch January 22, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants