feat!: Upgrade to casper-js-sdk 5.x #27
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volodymyr-Kuchinskyi
force-pushed
the
js-sdk-upgrade
branch
2 times, most recently
from
f0024f0 to
9524dba
Compare
Volodymyr-Kuchinskyi
force-pushed
the
js-sdk-upgrade
branch
from
9524dba to
27c1fa9
Compare
ihor
reviewed
Dec 19, 2024
| @@ -39,15 +39,15 @@ | |||
| "ts-results": "^3.3.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "casper-js-sdk": "^2.12.0" | |||
| "casper-js-sdk": "^5.0.0-rc8" | |||
There was a problem hiding this comment.
We'll release 5.0.0-beta1 tomorrow. Let's use it.
ihor
reviewed
Dec 19, 2024
| import { CLValue, decodeBase16, matchByteParserByCLType } from 'casper-js-sdk'; | ||
| import { WithRemainder } from './casper/types'; | ||
| import { CLValue, Hash, IResultWithBytes } from 'casper-js-sdk'; | ||
| import { toBytesString } from "casper-js-sdk/dist/types/ByteConverters"; |
There was a problem hiding this comment.
Why do we have dist in the path? This doesn't seem correct
ihor
requested changes
Jan 24, 2025
There was a problem hiding this comment.
@Volodymyr-Kuchinskyi please address the comment, update the SDK version to the latest, and add a test with Casper 2.0 Transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.