Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out-of-Schedule Mainnet Spell 2025-02-18 #453

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

amusingaxl
Copy link
Contributor

  • chore: port OOS spell to this repo

@amusingaxl amusingaxl changed the title 2025-02-18 Out-of-Schedule Spell Out-of-Schedule Mainnet Spell 2025-02-18 Feb 18, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tldr; Good to merge

  • ✅ Manual check ensures migrated code hans't been modified after full approval in a private PR
  • ✅ Ensure that the DssExecLib.address file is not being modified by the spell PR
  • ✅ Check all CI tests are passing as at the latest commit f24bbdc
  • ✅ Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_|DAPP_")
  • ✅ Check all tests are passing locally using make test
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠒] Compiling 5 files with Solc 0.8.16
[⠑] Solc 0.8.16 finished in 2.64s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 698150)
[PASS] testStarknetSpell() (gas: 2302)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 18.48s (14.27s CPU time)

Warning: the following cheatcode(s) are deprecated and will be removed in future versions:
  revertTo(uint256): replaced by `revertToState`
  snapshot(): replaced by `snapshotState`
Ran 41 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testAllocatorIntegration() (gas: 0)
[PASS] testBytecodeMatches() (gas: 1657176)
[PASS] testCastCost() (gas: 528458)
[PASS] testCastOnTime() (gas: 524208)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 10479683)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 30046340)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 1608401)
[PASS] testLockstakeIlkIntegration() (gas: 10142998)
[SKIP] testMedianReaders() (gas: 0)
[SKIP] testNewAuthorizations() (gas: 0)
[SKIP] testNewCronJobs() (gas: 0)
[PASS] testNextCastTime() (gas: 355874)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 16921)
[SKIP] testOracleList() (gas: 0)
[SKIP] testOsmReaders() (gas: 0)
[PASS] testPSMs() (gas: 1999290)
[SKIP] testPayments() (gas: 0)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17588)
[SKIP] testSparkSpellIsExecuted() (gas: 0)
[PASS] testSplitter() (gas: 1130146)
[PASS] testSystemTokens() (gas: 1968314)
[PASS] testUseEta() (gas: 354540)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testVestSKY() (gas: 0)
[SKIP] testVestSKYmint() (gas: 0)
[SKIP] testVestUSDS() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 14 passed; 0 failed; 27 skipped; finished in 344.59s (762.71s CPU time)

Ran 2 test suites in 345.14s (363.07s CPU time): 16 tests passed, 0 failed, 27 skipped (43 total tests)


  • foundry version Version: 1.0.0-stable was used.

Copy link
Member

@oddaf oddaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All files match the files in the private spell repo
  • DSSExecLib address was not touched in this PR
  • Bytecode matches the deployed spell
  • Local tests (below)
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠒] Compiling 7 files with Solc 0.8.16
[⠑] Solc 0.8.16 finished in 5.62s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 698150)
[PASS] testStarknetSpell() (gas: 2302)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 15.22s (11.92s CPU time)

Warning: the following cheatcode(s) are deprecated and will be removed in future versions:
  snapshot(): replaced by `snapshotState`
  revertTo(uint256): replaced by `revertToState`
Ran 41 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testAllocatorIntegration() (gas: 0)
[PASS] testBytecodeMatches() (gas: 1657176)
[PASS] testCastCost() (gas: 528458)
[PASS] testCastOnTime() (gas: 524208)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 10479683)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 30046340)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 1608401)
[PASS] testLockstakeIlkIntegration() (gas: 10142998)
[SKIP] testMedianReaders() (gas: 0)
[SKIP] testNewAuthorizations() (gas: 0)
[SKIP] testNewCronJobs() (gas: 0)
[PASS] testNextCastTime() (gas: 355874)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 16921)
[SKIP] testOracleList() (gas: 0)
[SKIP] testOsmReaders() (gas: 0)
[PASS] testPSMs() (gas: 1999290)
[SKIP] testPayments() (gas: 0)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17588)
[SKIP] testSparkSpellIsExecuted() (gas: 0)
[PASS] testSplitter() (gas: 1130146)
[PASS] testSystemTokens() (gas: 1968314)
[PASS] testUseEta() (gas: 354540)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testVestSKY() (gas: 0)
[SKIP] testVestSKYmint() (gas: 0)
[SKIP] testVestUSDS() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 14 passed; 0 failed; 27 skipped; finished in 294.58s (630.50s CPU time)

Ran 2 test suites in 295.27s (309.80s CPU time): 16 tests passed, 0 failed, 27 skipped (43 total tests)

@amusingaxl amusingaxl merged commit b474153 into master Feb 19, 2025
2 checks passed
@amusingaxl amusingaxl deleted the 2025-02-18-oos branch February 19, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants