Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dnsmasq ipset handing #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

maksimkurb
Copy link
Owner

@maksimkurb maksimkurb commented Feb 2, 2025

This pull request fixes #2

  • Write multiple ipset names per domain on one row
    # Write this:
    + ipset=/ifconfig.co/vpn,vpn_ipv6
    
    # Instead of this:
    - ipset=/ifconfig.co/vpn
    - ipset=/ifconfig.co/vpn_ipv6
  • Store only CRC32 of domain hostname instead of domain string to reduce RAM consumption while parsing lists
  • Warn user if there are CRC32 collisions occurred
  • Do not store all IPs/CIDRs in RAM, write them to ipset on the go
  • Do not write dnsmasq config file to disk if it was not changed
  • Remove old generated dnsmasq configs on upgrade
  • Upgrade old keenetic-pbr config on upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Handling of duplicate domain entries for DNSMasq
1 participant