machine/ncr5385.cpp: raise IRQ for INT_INVALID_CMD (#12524)

Elektraglide · web-flow · commit 25066795cade · 2024-07-07T10:16:23.000-04:00
* - tek4404 selftest writes 0xff as command (invalid command) and expects an IRQ to be raised

---------
Co-authored-by: Adam &lt;adam@light-up.co.uk&gt;
Co-authored-by: hap &lt;happppp@users.noreply.github.com&gt;
diff --git a/src/devices/machine/ncr5385.cpp b/src/devices/machine/ncr5385.cpp
@@ -421,6 +421,9 @@ void ncr5385_device::cmd_w(u8 data)
 		case 0x18: case 0x19: case 0x1a: case 0x1b:
 		case 0x1c: case 0x1d: case 0x1e: case 0x1f:
 			// reserved
+			LOGMASKED(LOG_COMMAND, "reserved / invalid cmd\n");
+			m_int_status |= INT_INVALID_CMD;
+			update_int();
 			break;
 		}
 	}
@@ -814,7 +817,8 @@ void ncr5385_device::set_dreq(bool dreq)
 
 void ncr5385_device::update_int()
 {
-	bool const int_state = m_int_status & 0x5f;
+	bool const int_state = m_int_status & (INT_FUNC_COMPLETE | INT_BUS_SERVICE |
+			INT_DISCONNECTED | INT_SELECTED | INT_RESELECTED | INT_INVALID_CMD);
 
 	if (m_int_state != int_state)
 	{

Original file line number	Diff line number	Diff line change
`@@ -421,6 +421,9 @@ void ncr5385_device::cmd_w(u8 data)`
`421`	`421`	`case 0x18: case 0x19: case 0x1a: case 0x1b:`
`422`	`422`	`case 0x1c: case 0x1d: case 0x1e: case 0x1f:`
`423`	`423`	`// reserved`
	`424`	`+ LOGMASKED(LOG_COMMAND, "reserved / invalid cmd\n");`
	`425`	`+ m_int_status \|= INT_INVALID_CMD;`
	`426`	`+ update_int();`
`424`	`427`	`break;`
`425`	`428`	`}`
`426`	`429`	`}`
`@@ -814,7 +817,8 @@ void ncr5385_device::set_dreq(bool dreq)`
`814`	`817`
`815`	`818`	`void ncr5385_device::update_int()`
`816`	`819`	`{`
`817`		`- bool const int_state = m_int_status & 0x5f;`
	`820`	`+ bool const int_state = m_int_status & (INT_FUNC_COMPLETE \| INT_BUS_SERVICE \|`
	`821`	`+ INT_DISCONNECTED \| INT_SELECTED \| INT_RESELECTED \| INT_INVALID_CMD);`
`818`	`822`
`819`	`823`	`if (m_int_state != int_state)`
`820`	`824`	`{`