Skip to content

Commit 9f6c0de

Browse files
committed
Cleaned up various stuff.
* sony_news.xml: Added proper compatibility flags for different generations. * cpu/pic16x8x: This is very much a derivative work. * cpu/tms32025.cpp: Allow stack push/pop to be inlined. * tecmo/bombjack.cpp: Avoid needing to remove and replace devices in machine configuration. * Various other cleanup.
1 parent db219fd commit 9f6c0de

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+1044
-1025
lines changed

hash/sony_news.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ license:CC0-1.0
1010
<year>1991</year>
1111
<publisher>Sony</publisher>
1212
<notes>The floppies can boot on both CISC and RISC systems due to some bootloader magic, but the MO image is only for the first wave of RISC NEWS machines (NWS-3000 series)</notes>
13-
<sharedfeat name="compatibility" value="RISC" />
13+
<sharedfeat name="compatibility" value="NWS3000" />
1414
<!--
1515
The installation floppy and MO disk work, but the format disk hangs after printing a few messages on RISC systems.
1616
Therefore, use of this kit requires use of a pre-formatted hard disk image for now.
@@ -44,7 +44,7 @@ license:CC0-1.0
4444
<year>1993</year>
4545
<publisher>Sony</publisher>
4646
<notes>Usable only on NWS-5000 series computers</notes>
47-
<sharedfeat name="compatibility" value="RISC" />
47+
<sharedfeat name="compatibility" value="NWS5000" />
4848

4949
<!-- Source: WinWorld -->
5050
<!-- The "STAMP" file has the build date of 05/05/93 -->

plugins/hiscore/hiscore.dat

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8093,6 +8093,7 @@ lupin3:
80938093
@:maincpu,program,20dc,03,00,00
80948094
@delay=0.25
80958095

8096+
80968097
invrvnge:
80978098
invrvngea:
80988099
invrvngeb:

src/devices/bus/hp_dio/hp98544.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@
1010

1111
#include "emu.h"
1212
#include "hp98544.h"
13-
#include "screen.h"
13+
1414
#include "video/topcat.h"
15-
#include "hp_dio.h"
15+
16+
#include "screen.h"
17+
1618

1719
#define HP98544_SCREEN_NAME "98544_screen"
1820
#define HP98544_ROM_REGION "98544_rom"

src/devices/bus/hp_dio/hp98603a.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
#include "emu.h"
1010
#include "hp98603a.h"
11-
#include "hp_dio.h"
11+
1212

1313
#define HP98603A_ROM_REGION "98603a_rom"
1414

src/devices/bus/hp_dio/hp98603b.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
#include "emu.h"
1010
#include "hp98603b.h"
11-
#include "hp_dio.h"
11+
1212

1313
#define HP98603B_ROM_REGION "98603b_rom"
1414

src/devices/bus/hp_dio/hp98620.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
#include "emu.h"
1010
#include "hp98620.h"
11-
#include "hp_dio.h"
1211

1312
#define VERBOSE 0
1413
#include "logmacro.h"

src/devices/bus/hp_dio/hp98624.cpp

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88

99
#include "emu.h"
1010
#include "hp98624.h"
11-
#include "machine/tms9914.h"
11+
1212
#include "bus/ieee488/ieee488.h"
13-
#include "hp_dio.h"
13+
#include "machine/tms9914.h"
1414

1515
//#define VERBOSE 1
1616
#include "logmacro.h"
@@ -42,6 +42,7 @@ class dio16_98624_device :
4242
required_device<tms9914_device> m_tms9914;
4343
required_device<ieee488_device> m_ieee488;
4444
required_ioport m_switches;
45+
4546
private:
4647
void update_gpib_irq();
4748
void update_gpib_dma();
@@ -101,17 +102,17 @@ dio16_98624_device::dio16_98624_device(const machine_config &mconfig, device_typ
101102
{
102103
}
103104

104-
#define REG_SWITCHES_SC 0x01
105-
#define REG_SWITCHES_REMOTE 0x02
105+
constexpr unsigned REG_SWITCHES_SC = 0x01;
106+
constexpr unsigned REG_SWITCHES_REMOTE = 0x02;
106107

107-
#define REG_SWITCHES_INT_LEVEL_MASK 3
108-
#define REG_SWITCHES_INT_LEVEL_SHIFT 2
108+
constexpr unsigned REG_SWITCHES_INT_LEVEL_MASK = 3;
109+
constexpr unsigned REG_SWITCHES_INT_LEVEL_SHIFT = 2;
109110

110-
#define REG_SWITCHES_SELECT_CODE_MASK 31
111-
#define REG_SWITCHES_SELECT_CODE_SHIFT 4
111+
constexpr unsigned REG_SWITCHES_SELECT_CODE_MASK = 31;
112+
constexpr unsigned REG_SWITCHES_SELECT_CODE_SHIFT = 4;
112113

113-
#define REG_SWITCHES_GPIB_ADDR_MASK 31
114-
#define REG_SWITCHES_GPIB_ADDR_SHIFT 9
114+
constexpr unsigned REG_SWITCHES_GPIB_ADDR_MASK = 31;
115+
constexpr unsigned REG_SWITCHES_GPIB_ADDR_SHIFT = 9;
115116

116117
static INPUT_PORTS_START(hp98624_port)
117118
PORT_START("switches")

src/devices/bus/hp_dio/hp98644.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@
88

99
#include "emu.h"
1010
#include "hp98644.h"
11+
1112
#include "bus/rs232/rs232.h"
1213
#include "machine/ins8250.h"
13-
#include "hp_dio.h"
14+
1415

1516
namespace {
1617

0 commit comments

Comments
 (0)