Skip to content

Commit a09fd45

Browse files
committed
rs232/pty: remove unused constexpr
1 parent 47cbeaa commit a09fd45

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

src/devices/bus/rs232/null_modem.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ static INPUT_PORTS_START(null_modem)
3737

3838
PORT_START("FLOW_CONTROL")
3939
PORT_CONFNAME(0x07, 0x00, "Flow Control")
40-
PORT_CONFSETTING(0x00, "Off")
41-
PORT_CONFSETTING(0x01, "RTS")
42-
PORT_CONFSETTING(0x02, "DTR")
43-
PORT_CONFSETTING(0x04, "XON/XOFF")
40+
PORT_CONFSETTING( 0x00, DEF_STR(Off))
41+
PORT_CONFSETTING( 0x01, "RTS")
42+
PORT_CONFSETTING( 0x02, "DTR")
43+
PORT_CONFSETTING( 0x04, "XON/XOFF")
4444
INPUT_PORTS_END
4545

4646
ioport_constructor null_modem_device::device_input_ports() const

src/devices/bus/rs232/pty.cpp

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
#include <cstdio>
88

99

10-
static constexpr int TIMER_POLL = 1;
11-
1210
pseudo_terminal_device::pseudo_terminal_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) :
1311
device_t(mconfig, PSEUDO_TERMINAL, tag, owner, clock),
1412
device_serial_interface(mconfig, *this),
@@ -60,12 +58,13 @@ static INPUT_PORTS_START(pseudo_terminal)
6058
PORT_RS232_DATABITS("RS232_DATABITS", RS232_DATABITS_8, "Data Bits", pseudo_terminal_device, update_serial)
6159
PORT_RS232_PARITY("RS232_PARITY", RS232_PARITY_NONE, "Parity", pseudo_terminal_device, update_serial)
6260
PORT_RS232_STOPBITS("RS232_STOPBITS", RS232_STOPBITS_1, "Stop Bits", pseudo_terminal_device, update_serial)
61+
6362
PORT_START("FLOW_CONTROL")
6463
PORT_CONFNAME(0x07, 0x00, "Flow Control")
65-
PORT_CONFSETTING(0x00, "Off")
66-
PORT_CONFSETTING(0x01, "RTS")
67-
PORT_CONFSETTING(0x02, "DTR")
68-
PORT_CONFSETTING(0x04, "XON/XOFF")
64+
PORT_CONFSETTING( 0x00, DEF_STR(Off))
65+
PORT_CONFSETTING( 0x01, "RTS")
66+
PORT_CONFSETTING( 0x02, "DTR")
67+
PORT_CONFSETTING( 0x04, "XON/XOFF")
6968
INPUT_PORTS_END
7069

7170
ioport_constructor pseudo_terminal_device::device_input_ports() const
@@ -136,7 +135,7 @@ TIMER_CALLBACK_MEMBER(pseudo_terminal_device::update_queue)
136135
if (m_input_index == m_input_count)
137136
{
138137
m_input_index = 0;
139-
int const tmp = read(m_input_buffer , sizeof(m_input_buffer));
138+
int const tmp = read(m_input_buffer, sizeof(m_input_buffer));
140139
if (tmp > 0)
141140
m_input_count = tmp;
142141
else

src/devices/bus/rs232/pty.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class pseudo_terminal_device : public device_t,
4141
required_ioport m_rs232_stopbits;
4242
required_ioport m_flow;
4343

44-
uint8_t m_input_buffer[ 1024 ];
44+
uint8_t m_input_buffer[1024];
4545
uint32_t m_input_count;
4646
uint32_t m_input_index;
4747
emu_timer *m_timer_poll;

src/emu/dipty.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class device_pty_interface : public device_interface
2727

2828
bool is_open() const;
2929

30-
ssize_t read(u8 *rx_chars , size_t count) const;
30+
ssize_t read(u8 *rx_chars, size_t count) const;
3131
void write(u8 tx_char) const;
3232

3333
bool is_slave_connected() const;

0 commit comments

Comments
 (0)