rs232/pty: remove unused constexpr

mamedev · Dec 19, 2023 · a09fd45 · a09fd45
1 parent 47cbeaa
commit a09fd45
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 13 deletions.
diff --git a/src/devices/bus/rs232/null_modem.cpp b/src/devices/bus/rs232/null_modem.cpp
@@ -37,10 +37,10 @@ static INPUT_PORTS_START(null_modem)
 
 	PORT_START("FLOW_CONTROL")
 	PORT_CONFNAME(0x07, 0x00, "Flow Control")
-	PORT_CONFSETTING(0x00, "Off")
-	PORT_CONFSETTING(0x01, "RTS")
-	PORT_CONFSETTING(0x02, "DTR")
-	PORT_CONFSETTING(0x04, "XON/XOFF")
+	PORT_CONFSETTING(   0x00, DEF_STR(Off))
+	PORT_CONFSETTING(   0x01, "RTS")
+	PORT_CONFSETTING(   0x02, "DTR")
+	PORT_CONFSETTING(   0x04, "XON/XOFF")
 INPUT_PORTS_END
 
 ioport_constructor null_modem_device::device_input_ports() const

diff --git a/src/devices/bus/rs232/pty.cpp b/src/devices/bus/rs232/pty.cpp
@@ -7,8 +7,6 @@
 #include <cstdio>
 
 
-static constexpr int TIMER_POLL = 1;
-
 pseudo_terminal_device::pseudo_terminal_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) :
 	device_t(mconfig, PSEUDO_TERMINAL, tag, owner, clock),
 	device_serial_interface(mconfig, *this),
@@ -60,12 +58,13 @@ static INPUT_PORTS_START(pseudo_terminal)
 	PORT_RS232_DATABITS("RS232_DATABITS", RS232_DATABITS_8, "Data Bits", pseudo_terminal_device, update_serial)
 	PORT_RS232_PARITY("RS232_PARITY", RS232_PARITY_NONE, "Parity", pseudo_terminal_device, update_serial)
 	PORT_RS232_STOPBITS("RS232_STOPBITS", RS232_STOPBITS_1, "Stop Bits", pseudo_terminal_device, update_serial)
+
 	PORT_START("FLOW_CONTROL")
 	PORT_CONFNAME(0x07, 0x00, "Flow Control")
-	PORT_CONFSETTING(0x00, "Off")
-	PORT_CONFSETTING(0x01, "RTS")
-	PORT_CONFSETTING(0x02, "DTR")
-	PORT_CONFSETTING(0x04, "XON/XOFF")
+	PORT_CONFSETTING(   0x00, DEF_STR(Off))
+	PORT_CONFSETTING(   0x01, "RTS")
+	PORT_CONFSETTING(   0x02, "DTR")
+	PORT_CONFSETTING(   0x04, "XON/XOFF")
 INPUT_PORTS_END
 
 ioport_constructor pseudo_terminal_device::device_input_ports() const
@@ -136,7 +135,7 @@ TIMER_CALLBACK_MEMBER(pseudo_terminal_device::update_queue)
 		if (m_input_index == m_input_count)
 		{
 			m_input_index = 0;
-			int const tmp = read(m_input_buffer , sizeof(m_input_buffer));
+			int const tmp = read(m_input_buffer, sizeof(m_input_buffer));
 			if (tmp > 0)
 				m_input_count = tmp;
 			else

diff --git a/src/devices/bus/rs232/pty.h b/src/devices/bus/rs232/pty.h
@@ -41,7 +41,7 @@ class pseudo_terminal_device : public device_t,
 	required_ioport m_rs232_stopbits;
 	required_ioport m_flow;
 
-	uint8_t m_input_buffer[ 1024 ];
+	uint8_t m_input_buffer[1024];
 	uint32_t m_input_count;
 	uint32_t m_input_index;
 	emu_timer *m_timer_poll;

diff --git a/src/emu/dipty.h b/src/emu/dipty.h
@@ -27,7 +27,7 @@ class device_pty_interface : public device_interface
 
 	bool is_open() const;
 
-	ssize_t read(u8 *rx_chars , size_t count) const;
+	ssize_t read(u8 *rx_chars, size_t count) const;
 	void write(u8 tx_char) const;
 
 	bool is_slave_connected() const;