Skip to content

Commit d7ebf32

Browse files
authored
konami/simpsons.cpp: Don't need if - while will be skipped entirely if condition isn't met.
1 parent 76dc2c1 commit d7ebf32

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

src/mame/konami/simpsons.cpp

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ GX072 PWB352346B
113113
#include "emupal.h"
114114
#include "speaker.h"
115115

116+
#include <algorithm>
117+
116118

117119
namespace {
118120

@@ -599,7 +601,6 @@ INPUT_PORTS_END
599601
void simpsons_state::object_dma()
600602
{
601603
uint16_t *dst;
602-
603604
m_k053246->k053247_get_ram(&dst);
604605

605606
uint16_t const *src = m_spriteram.get();
@@ -609,20 +610,16 @@ void simpsons_state::object_dma()
609610
{
610611
if (BIT(*src, 15) && (*src & 0xff))
611612
{
612-
memcpy(dst, src, 0x10);
613-
dst += 8;
613+
dst = std::copy_n(src, 8, dst);
614614
num_inactive--;
615615
}
616616
src += 8;
617617
}
618618

619-
if (num_inactive)
619+
while (num_inactive--)
620620
{
621-
while (num_inactive--)
622-
{
623-
*dst = 0;
624-
dst += 8;
625-
}
621+
*dst = 0;
622+
dst += 8;
626623
}
627624
}
628625

0 commit comments

Comments
 (0)