Skip to content

Commit eab0eb4

Browse files
committed
nec/8401a.cpp: make palette a bit better
1 parent a0a91cf commit eab0eb4

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

src/mame/nec/pc8401a.cpp

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,14 @@
1010
- keyboard key modifiers (f6-f10 presumably needs holding shift like PC-8001);
1111
\- Option testing beyond f5;
1212
\- Cannot do anything useful with filer (usage: "filer <filename>"), needs F6;
13-
- RTC TP pulse
13+
- blinking, uses unimplemented cursor in graphics mode for SED1330;
14+
- RTC TP pulse;
1415
- some unclear bits in the banking scheme;
15-
- mirror e800-ffff to 6800-7fff (why? -AS)
16-
- How PC-8508A really banks?
17-
- soft power on/off
18-
- idle sleep timer off by a bunch of seconds (option -> power to test);
19-
- NVRAM
16+
- mirror e800-ffff to 6800-7fff (why? -AS);
17+
- How PC-8508A really banks? Seems to select with I/O $31 and 0x8000-0xbfff;
18+
- soft power on/off;
19+
- idle sleep timer off by a bunch of seconds ("option" -> "power" to test);
20+
- NVRAM, saner QoL defaults (filling with 0xe5 should be enough);
2021
- 8251 USART
2122
- 8255 ports
2223
- PC-8431A FDC is same family as PC-80S31K, basically the 3.5" version of it.
@@ -164,8 +165,9 @@ class pc8401a_state : public driver_device
164165

165166
void pc8401a_state::palette_init(palette_device &palette) const
166167
{
167-
palette.set_pen_color(0, rgb_t(39, 108, 51));
168-
palette.set_pen_color(1, rgb_t(16, 37, 84));
168+
// TODO: actual values
169+
palette.set_pen_color(0, rgb_t(160, 168, 160));
170+
palette.set_pen_color(1, rgb_t(48, 56, 16));
169171
}
170172

171173
void pc8401a_state::pc8401a_lcdc(address_map &map)
@@ -580,6 +582,7 @@ void pc8401a_state::pc8500(machine_config &config)
580582
/* I/O ROM cartridge */
581583
GENERIC_CARTSLOT(config, m_io_cart, generic_linear_slot, nullptr, "bin,rom");
582584

585+
// TODO: wrong, should touch external cart only and have 32K & 128K options, plus be a slot NVRAM anyway.
583586
RAM(config, RAM_TAG).set_default_size("64K").set_extra_options("96K");
584587
}
585588

src/mame/nec/pc98ha.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232

3333
void pc98lt_state::lt_palette(palette_device &palette) const
3434
{
35+
// TODO: confirm values
3536
palette.set_pen_color(0, 160, 168, 160);
3637
palette.set_pen_color(1, 48, 56, 16);
3738
}

0 commit comments

Comments
 (0)