treat banking behavior as a potential difference between SoC types

Author: David Haywood

src/mame/tvgames/elan_eu3a05.cpp

@@ -875,16 +875,18 @@ void elan_eu3a05_state::elan_eu3a05_pal(machine_config& config)
 void elan_eu3a13_state::elan_eu3a13(machine_config& config)
 {
 	elan_eu3a05(config);
+	m_maincpu->set_addrmap(AS_PROGRAM, &elan_eu3a13_state::elan_eu3a13_map);
 
 	ELAN_EU3A13_VID(config.replace(), m_vid, 0);
 	m_vid->set_cpu("maincpu");
 	m_vid->set_addrbank("bank");
 	m_vid->set_palette("palette");
 	m_vid->set_entries(256);
 
-	m_maincpu->set_addrmap(AS_PROGRAM, &elan_eu3a13_state::elan_eu3a13_map);
+	ELAN_EU3A13_SYS(config.replace(), m_sys, 0);
+	m_sys->set_cpu("maincpu");
+	m_sys->set_addrbank("bank");
 	m_sys->set_alt_timer(); // for Carl Edwards'
-	m_sys->set_bank_on_low_writes(); // for rad_ftet
 }
 
 void elan_eu3a13_state::elan_eu3a13_pal(machine_config& config)

src/mame/tvgames/elan_eu3a05commonsys.h

@@ -26,7 +26,6 @@ class elan_eu3a05commonsys_device : public device_t
 	uint8_t irq_vector_r(offs_t offset);
 
 	void set_alt_timer() { m_whichtimer = 1; }
-	void set_bank_on_low_writes() { m_bank_on_low_bank_writes = true; }
 protected:
 	// device-level overrides
 	virtual void device_start() override ATTR_COLD;

src/mame/tvgames/elan_eu3a05sys.cpp

@@ -7,14 +7,28 @@
 // DMA size and destination are 16-bit here, they're 24-bit on EU3A14
 
 DEFINE_DEVICE_TYPE(ELAN_EU3A05_SYS, elan_eu3a05sys_device, "elan_eu3a05sys", "Elan EU3A05 System")
+DEFINE_DEVICE_TYPE(ELAN_EU3A13_SYS, elan_eu3a13sys_device, "elan_eu3a13sys", "Elan EU3A13 System")
 
-elan_eu3a05sys_device::elan_eu3a05sys_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) :
-	elan_eu3a05commonsys_device(mconfig, ELAN_EU3A05_SYS, tag, owner, clock),
+elan_eu3a05sys_device::elan_eu3a05sys_device(const machine_config &mconfig, device_type type, const char *tag, device_t *owner, uint32_t clock) :
+	elan_eu3a05commonsys_device(mconfig, type, tag, owner, clock),
 	device_memory_interface(mconfig, *this),
 	m_space_config("regs", ENDIANNESS_NATIVE, 8, 5, 0, address_map_constructor(FUNC(elan_eu3a05sys_device::map), this))
 {
 }
 
+elan_eu3a05sys_device::elan_eu3a05sys_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) :
+	elan_eu3a05sys_device(mconfig, ELAN_EU3A05_SYS, tag, owner, clock)
+{
+}
+
+elan_eu3a13sys_device::elan_eu3a13sys_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) :
+	elan_eu3a05sys_device(mconfig, ELAN_EU3A13_SYS, tag, owner, clock)
+{
+	// might be a difference on this hardware type, as rad_ftet (EU3A13) needs it, but rad_sinv (EU3A05) does not
+	m_bank_on_low_bank_writes = true;
+}
+
+
 device_memory_interface::space_config_vector elan_eu3a05sys_device::memory_space_config() const
 {
 	return space_config_vector {

src/mame/tvgames/elan_eu3a05sys.h

@@ -20,6 +20,8 @@ class elan_eu3a05sys_device : public elan_eu3a05commonsys_device, public device_
 	virtual void map(address_map &map) override ATTR_COLD;
 
 protected:
+	elan_eu3a05sys_device(const machine_config &mconfig, device_type type, const char *tag, device_t *owner, uint32_t clock);
+
 	// device-level overrides
 	virtual void device_start() override ATTR_COLD;
 	virtual void device_reset() override ATTR_COLD;
@@ -30,6 +32,14 @@ class elan_eu3a05sys_device : public elan_eu3a05commonsys_device, public device_
 	uint8_t m_dmaparams[7];
 };
 
+
+class elan_eu3a13sys_device : public elan_eu3a05sys_device
+{
+public:
+	elan_eu3a13sys_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock);
+};
+
 DECLARE_DEVICE_TYPE(ELAN_EU3A05_SYS, elan_eu3a05sys_device)
+DECLARE_DEVICE_TYPE(ELAN_EU3A13_SYS, elan_eu3a13sys_device)
 
 #endif // MAME_TVGAMES_ELAN_EU3A05SYS_H