Skip to content

windows conda build #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

windows conda build #2604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ae30b0
cmake fixes for windows-conda builds
Klaim Aug 14, 2025
d68fa1a
cmake preset for conda use build type RelWithDebInfo by default
Klaim Aug 14, 2025
d333467
makes conda env. libs available when using conda - worksaround boost …
Klaim Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ if(ARCTICDB_SANITIZER_FLAGS)
message(STATUS "Building ArcticDB with sanitizers. Compiler flags: ${ARCTICDB_SANITIZER_FLAGS}")
endif()

if(${ARCTICDB_USING_CONDA})
# Required to be able to include headers from glog since glog 0.7
# See: https://github.com/google/glog/pull/1030
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DGLOG_USE_GLOG_EXPORT")
endif()

if(WIN32)
add_compile_definitions(
NOGDI WIN32_LEAN_AND_MEAN HAVE_SNPRINTF NOMINMAX
Expand All @@ -85,9 +91,22 @@ if(WIN32)
# Guide to MSVC compilation warnings https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warnings-c4000-through-c4199?view=msvc-170
add_compile_options(
/DWIN32 /D_WINDOWS /GR /EHsc /bigobj /Z7 /wd4244 /wd4267
"$<$<CONFIG:Debug>:/Od;/MTd>"
"$<$<CONFIG:Release>:/MT;/Ox>"
)

if(${ARCTICDB_USING_CONDA})
# Conda builds use dynamic linkage
add_compile_options(
"$<$<CONFIG:Debug>:/MDd>"
"$<$<CONFIG:Release>:/MD;/Ox>"
)
else()
# PyPI builds use static linkage
add_compile_options(
"$<$<CONFIG:Debug>:/Od;/MTd>"
"$<$<CONFIG:Release>:/MT;/Ox>"
)
endif()

if(${ARCTICDB_MSVC_OMIT_RUNTIME_CHECKS})
message(STATUS "Removing MSVC runtime checks")
foreach(flag_var CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE CMAKE_CXX_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_RELWITHDEBINFO)
Expand All @@ -96,9 +115,7 @@ if(WIN32)
endif()
else()
if(${ARCTICDB_USING_CONDA})
# Required to be able to include headers from glog since glog 0.7
# See: https://github.com/google/glog/pull/1030
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -DGLOG_USE_GLOG_EXPORT")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra")
else()
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
endif()
Expand Down
5 changes: 4 additions & 1 deletion cpp/CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@
},
{
"name": "windows-cl-conda-debug",
"inherits": ["common_conda", "windows"]
"inherits": ["common_conda", "windows"],
"cacheVariables": {
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},

{
Expand Down
5 changes: 5 additions & 0 deletions cpp/arcticdb/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ else()

set(Zstd_LIBRARY zstd::libzstd_shared)

# Make sure libraries using auto-linking (Boost) are found when using a Conda env
if(MSVC)
link_directories("$ENV{CONDA_PREFIX}/Library/lib/")
endif()

endif()

if(${ARCTICDB_USING_CONDA} OR CMAKE_SYSTEM_NAME STREQUAL "Darwin")
Expand Down
Loading