ASV benchmarks for bool column truncation#3054
Merged
Conversation
|
|
||
| def time_read_row_range_byte_unaligned(self, rows, sparsity): | ||
| # Should read the first two blocks and truncate both to a byte unaligned offsets | ||
| self.lib.read(self.sym, row_range=(5, 100_005)) |
Contributor
There was a problem hiding this comment.
Consider adding peakmem_read_row_range_byte_aligned and peakmem_read_row_range_byte_unaligned counterparts to match the existing time_*/peakmem_* pairing pattern used for time_read/peakmem_read and time_write/peakmem_write. Memory usage during truncation may differ meaningfully between aligned and unaligned cases.
Contributor
ArcticDB Code Review SummaryAPI & Compatibility
Memory & Safety
Correctness
Code Quality
Testing
Build & Dependencies
Security
PR Title & Description
Documentation
Side-effect note (informational): The setup_cache_key values for ArrowStrings benchmarks changed from arrow:263 to arrow:271 in benchmarks.json because inserting 8 new lines into ArrowBools shifted those line numbers. This is correct ASV behaviour and will simply invalidate the cached setup for those benchmarks on the next run -- no action needed. |
alexowens90
approved these changes
Apr 22, 2026
ognyanstoimenov
approved these changes
Apr 28, 2026
maxim-morozov
pushed a commit
that referenced
this pull request
Apr 29, 2026
#### Reference Issues/PRs New benchmarks for memcpy bool truncation. Useful for benchmarking follow up PR #3052 #### What does this implement or fix? #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing --> Co-authored-by: Ivo <ivo.dilov@man.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
New benchmarks for memcpy bool truncation.
Useful for benchmarking follow up PR #3052
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...