Skip to content

fix(iroh): carry cmux transport fixes on v1.0.2#3

Draft
azooz2003-bit wants to merge 7 commits into
mainfrom
fix/cmux-iroh-1.0.2-bounds-relay-refresh
Draft

fix(iroh): carry cmux transport fixes on v1.0.2#3
azooz2003-bit wants to merge 7 commits into
mainfrom
fix/cmux-iroh-1.0.2-bounds-relay-refresh

Conversation

@azooz2003-bit

@azooz2003-bit azooz2003-bit commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Base the cmux core fork on Iroh v1.0.2, including the transport-lane receive fairness fix needed by multi-stream consumers.
  • Preserve fork main's post-release Crossbeam 0.9.20 invalid-pointer fix.
  • Replay the bounded path-open retry queue, abandoned address-lookup cancellation, and same-URL relay token refresh changes without modifying their patches.

The seven replayed commits are patch-identical to their original history according to git range-diff.

Breaking Changes

None.

Testing

  • cargo test -p iroh --all-features: 120 unit tests passed, 1 ignored; 1 integration test passed; 26 doc tests passed, 2 ignored
  • cargo fmt --all -- --check
  • cargo check -p iroh --all-features --all-targets
  • cargo clippy -p iroh --all-features --all-targets -- -D warnings

Notes

This branch supersedes the consumer pin from the earlier bounded-retry and relay-refresh PRs while preserving both PR histories:


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.


Summary by cubic

Rebased our iroh fork onto v1.0.2 and fixed cmux transport issues: cancelled lookups are released, path-open retries are bounded, and relay token rotation at the same URL restarts only the relay client without dropping existing connections.

  • Bug Fixes

    • Cancel and drop hanging address lookups when a connect is aborted; stop lookup stream when no waiters remain.
    • Bound and deduplicate the pending path-open retry queue to 64 entries to prevent unbounded growth across multi-connection retries.
    • On same-URL relay config changes (e.g., token rotation), restart the active relay client with the new token while preserving endpoint identity and existing QUIC connections; keep advertising the prior home relay until a replacement is selected.
  • Dependencies

    • Based on iroh v1.0.2, pulling in the transport receive fairness fix for multi-stream consumers.
    • Preserves the crossbeam 0.9.20 invalid-pointer fix.

Written for commit 8295188. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ba95b291-e6e7-4d6b-b7f9-38a760972734

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cmux-iroh-1.0.2-bounds-relay-refresh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant