fix(iroh): carry cmux transport fixes on v1.0.2#3
Draft
azooz2003-bit wants to merge 7 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The seven replayed commits are patch-identical to their original history according to git range-diff.
Breaking Changes
None.
Testing
Notes
This branch supersedes the consumer pin from the earlier bounded-retry and relay-refresh PRs while preserving both PR histories:
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Rebased our
irohfork onto v1.0.2 and fixed cmux transport issues: cancelled lookups are released, path-open retries are bounded, and relay token rotation at the same URL restarts only the relay client without dropping existing connections.Bug Fixes
Dependencies
irohv1.0.2, pulling in the transport receive fairness fix for multi-stream consumers.crossbeam0.9.20 invalid-pointer fix.Written for commit 8295188. Summary will update on new commits.