[common.vm] Improve VM-Write-Log#1249
Merged
sara-rn merged 1 commit intomandiant:mainfrom Jan 22, 2025
Merged
Conversation
Improve console output of VM-Write-Log: - Use $message instead of $line as it makes the output difficult to read. This information is only useful in the file. - Use better colors. Also remove unused levels (`FATAL`, `DEBUG`) and improve the function help message.
sara-rn
approved these changes
Jan 22, 2025
Contributor
sara-rn
left a comment
sara-rn
left a comment
There was a problem hiding this comment.
tested locally, works as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve console output of
VM-Write-Log:$messageinstead of$lineas it makes the output difficult to read. This information is only useful in the file.Also remove unused levels (
FATAL,DEBUG) and improve the function help message.Example: idapro.vm before the change
Example: idapro.vm after the change
idapro.vm added in #1243
Related: #1244