Add tests (and refactor) API extraction and symbol generation #2597
Conversation
Signed-off-by: vibhatsu <[email protected]>
Signed-off-by: vibhatsu <[email protected]>
Signed-off-by: vibhatsu <[email protected]>
| assert trim_dll_part("kernel32.CreateFileA") == "CreateFileA" | ||
| assert trim_dll_part("System.Convert::FromBase64String") == "System.Convert::FromBase64String" | ||
| assert trim_dll_part("System.Diagnostics.Debugger::IsLogging") == "System.Diagnostics.Debugger::IsLogging" | ||
| assert trim_dll_part("ws2_32.#1") == "ws2_32.#1" |
There was a problem hiding this comment.
this seems inconsistent to me:
assert trim_dll_part("kernel32.CreateFileA") == "CreateFileA" only export name.
assert trim_dll_part("ws2_32.#1") == "ws2_32.#1" both DLL and export name.
would you please continue to explore how this code is used (e.g., review the callers) and consider if further refactoring needs to be done to make the code less surprising?
There was a problem hiding this comment.
I don't think so we can remove the dll part for ordinal function. Reason: ordinal is meaningless without the dll part. In case of named functions, only a single library contains them and exports them but ordinal is same for all libraries.
There was a problem hiding this comment.
This function is used for api and count(api:<api_name>) statement building
closes #1899
Checklist