Align focused cpp/h codestyle#290
Closed
billy1arm wants to merge 1 commit into
Closed
Conversation
Apply the updated inline-body brace rule to the linked-reference and group accessor headers touched by the new CodingStandard wording.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Aligns several linked-reference and group-related headers with the updated CodingStandard requirement that inline function/ctor/dtor bodies must not appear on the same line as their declarations (Allman-style braces).
Changes:
- Reformatted inline constructors/destructors and short accessors to move bodies onto separate brace blocks.
- Applied the same brace/style adjustment across linked list / linked reference utilities and group/map reference manager headers.
- Updated a set of small inline accessors/iterators in touched headers to match the clarified standard.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/Utilities/LinkedReference/RefManager.h | Reformats inline ctor/dtor and iterator/accessor bodies to Allman-style braces. |
| src/shared/Utilities/LinkedReference/Reference.h | Reformats inline dtor and small accessors (next/prev, etc.) to match inline-body brace rule. |
| src/shared/Utilities/LinkedList.h | Reformats inline ctor/dtor and small list navigation helpers to match inline-body brace rule. |
| src/game/WorldHandlers/Group.h | Reformats small inline accessors and a couple of trivial ctors/dtors to conform to the updated style guidance. |
| src/game/References/MapRefManager.h | Reformats small iterator/accessor bodies to the updated inline brace style. |
| src/game/References/MapReference.h | Reformats inline ctor/dtor and accessors; retains existing API surface. |
| src/game/References/HostileRefManager.h | Reformats small inline getters to the updated inline brace style. |
| src/game/References/GroupRefManager.h | Reformats inline accessors to match the updated brace rule. |
| src/game/References/GroupReference.h | Reformats inline ctor/dtor and accessors to match the updated brace rule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+112
to
+115
| MapReference* nockeck_prev() | ||
| { | ||
| return (MapReference*)Reference<Map, Player>::nocheck_prev(); | ||
| } |
Comment on lines
+88
to
+91
| bool hasNext() const | ||
| { | ||
| return (iNext->iNext != NULL); | ||
| } |
Comment on lines
+97
to
+100
| bool hasPrev() const | ||
| { | ||
| return (iPrev->iPrev != NULL); | ||
| } |
r-log
added a commit
to r-log/server-three
that referenced
this pull request
Jul 12, 2026
…peners (mangosthree#290) Port of mangozero PR mangosthree#290 (fd31c6c), adapted for Cata 4.3.4. Core fix: CastComboAction::isUseful() read combo points with qualifier "self target" instead of "current target". ComboPointsValue::Calculate zeroes out unless the queried target's guid matches bot->GetComboTargetGuid() (the enemy currently being combo'd, not the bot itself), so combo always read 0 and the "combo < 5" builder gate was permanently true while any combo-gated finisher check would have been permanently false. Finishers (eviscerate/rupture/slice and dice/expose armor/kidney shot) previously had no combo gate at all; added CastFinishingMoveAction base class gating them on combo >= 1, plus a DPS-rotation trigger ("combo points for target available") that escalates the combo threshold per-target (1-2 vs 3-5 for elites+) mirroring m0. Also ports: stealthed-opener hierarchy (CastStealthedOpeningAction gates sap/garrote/cheap shot on the stealth aura; garrote additionally requires "behind"), begin/end sap and begin/end ambush actions wired through new "ambush"/"sap" strategies, and non-combat trigger wiring (attack -> begin ambush, sap -> begin sap, stealth -> stealth). Dropped the "pull" strategy registration from RogueAiObjectContext, matching upstream. Cata adaptation: m0's RogueSapStrategy uses action name "follow master"; our ActionContext only registers "follow" for FollowMasterAction, so the ported strategy uses "follow" instead. Spell names verified against Spell.dbc (build 15595): stealth 1784, sap 6770, garrote 703, cheap shot 1833, sinister strike 1752, backstab 53, mutilate 1329, slice and dice 5171, rupture 1943, eviscerate 2098, expose armor 8647, kidney shot 408 - all castable, no substitutions needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the updated inline-body brace rule to the linked-reference and group accessor headers touched by the new CodingStandard wording.\n\nCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
This change is