[Fix] Restore weekly and monthly quest reset triggers#292
Merged
Conversation
Commit c78d819 (2016) removed the World::Update() checks that fire ResetWeeklyQuests() and ResetMonthlyQuests(), so neither reset ran during uptime; weekly/monthly were only caught by the init-time normalization at the next restart. The reset functions, init functions, members and saved_variables columns all survived, so this is code-only (no schema change, no migration). Re-add the two Update() trigger blocks next to the existing daily reset, matching the daily wiring and the MangosTwo shape. The random-BG trigger the same 2016 commit removed is deliberately NOT restored: its first-win-of-day bonus mechanic does not exist in the Cata core (no IsRandom()/GetRandomWinner() reward path; m_IsBGRandomWinner is an unused member; character_battleground_random is absent from the schema). Restoring it would only churn NextRandomBGResetTime daily against data nothing reads. Wiring the real feature is a separate, larger task.
r-log
added a commit
to r-log/server-three
that referenced
this pull request
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
World::Update()fires only the daily-quest reset. The weekly and monthly triggers were removed byc78d8199d(2016, "Unused code removed").ResetWeeklyQuests()/ResetMonthlyQuests()still exist and their init still runs at startup, but nothing calls them at runtime — so weekly and monthly quests never reset during uptime (only maybe caught at restart). mangostwo fires all four.Restores the two
Update()checks next to the daily one. Code-only, no schema change.Random-BG was intentionally NOT restored:
c78d8199dcorrectly removed it because thecharacter_battleground_randomtable and the winner-API don't exist in Cata, so re-adding it would be an inert no-op.This change is