Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grocyproducts again #16

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

GoodOldJack12
Copy link
Contributor

@GoodOldJack12 GoodOldJack12 commented Sep 4, 2024

Fixed the actual issue in the button's disable check. Fixes a regression from #14

@GoodOldJack12 GoodOldJack12 force-pushed the fix-grocyproducts-again branch 2 times, most recently from b6a5687 to 368362e Compare September 4, 2024 11:25
@GoodOldJack12
Copy link
Contributor Author

Related: #12

@GoodOldJack12 GoodOldJack12 marked this pull request as ready for review September 4, 2024 11:29
@GoodOldJack12 GoodOldJack12 marked this pull request as draft September 4, 2024 12:07
@GoodOldJack12 GoodOldJack12 force-pushed the fix-grocyproducts-again branch from 368362e to 892ee5a Compare September 4, 2024 12:17
@GoodOldJack12
Copy link
Contributor Author

Now properly tested for the following cases:

  • Can purchase completely unknown product
  • Can purchase provider-known product
  • Can purchase grocy-known product

@GoodOldJack12 GoodOldJack12 marked this pull request as ready for review September 4, 2024 12:19
@manuel-rw manuel-rw changed the title Fix grocyproducts again fix: grocyproducts again Sep 4, 2024
@manuel-rw manuel-rw merged commit 1729abb into manuel-rw:master Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants