Adding support for NSCopying protocol.
#200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Nov 8, 2017
| /** | ||
| Returns a copy of the object. | ||
| - parameter zone: an NSZone to use in the copy operation. | ||
| - returns: A copy of the object. |
There was a problem hiding this comment.
I think this method already inherits documentation from the protocol’s method declaration, at least as far as Quick Help and other tools are concerned.
added 2 commits
November 8, 2017 16:20
|
Would it be possible to avoid all this boilerplate code by adopting Codable now that we're on an Xcode 9 stack already? |
|
I agree @frederoni, but wouldn't it be better to do that refactor in one tech-debt chore, rather than piecemeal? There are 8 classes that use |
1ec5
approved these changes
Nov 9, 2017
| } | ||
|
|
||
| @objc(isEqualToRouteOptions:) | ||
| open func isEqual(to routeOptions: RouteOptions?) -> Bool { |
There was a problem hiding this comment.
Cool, this gets us a little bit closer to implementing #151. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the box. Making
RouteObjectconform toNSCopying. Needed for mapbox/mapbox-navigation-ios#806./cc @1ec5 @bsudekum