Skip to content

Commit

Permalink
remove unnecessary sensor apis (#5020)
Browse files Browse the repository at this point in the history
  • Loading branch information
Guardiola31337 authored Oct 20, 2021
1 parent 29621db commit 5d5117e
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 577 deletions.
32 changes: 0 additions & 32 deletions libnavigation-core/api/current.txt
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ package com.mapbox.navigation.core {
method public void unregisterRoutesObserver(com.mapbox.navigation.core.directions.session.RoutesObserver routesObserver);
method public void unregisterTripSessionStateObserver(com.mapbox.navigation.core.trip.session.TripSessionStateObserver tripSessionStateObserver);
method public void unregisterVoiceInstructionsObserver(com.mapbox.navigation.core.trip.session.VoiceInstructionsObserver voiceInstructionsObserver);
method public void updateSensorEvent(android.hardware.SensorEvent sensorEvent, com.mapbox.navigation.core.trip.session.SensorEventUpdatedCallback callback);
property public final com.mapbox.navigator.Experimental experimental;
property public final com.mapbox.navigation.core.trip.session.eh.GraphAccessor graphAccessor;
property public final com.mapbox.navigation.core.history.MapboxHistoryRecorder historyRecorder;
Expand Down Expand Up @@ -541,33 +540,6 @@ package com.mapbox.navigation.core.routeoptions {

}

package com.mapbox.navigation.core.sensors {

public final class SensorEventEmitter implements android.hardware.SensorEventListener {
ctor public SensorEventEmitter(android.hardware.SensorManager sensorManager);
method public void onAccuracyChanged(android.hardware.Sensor? sensor, int accuracy);
method public void onSensorChanged(android.hardware.SensorEvent event);
method public void start(com.mapbox.navigation.core.sensors.SensorOptions sensorOptions, kotlin.jvm.functions.Function1<? super android.hardware.SensorEvent,kotlin.Unit> eventEmitter);
method public void stop();
}

public final class SensorOptions {
method public java.util.Set<java.lang.Integer> getEnableSensorTypes();
method public int getSignalsPerSecond();
method public com.mapbox.navigation.core.sensors.SensorOptions.Builder toBuilder();
property public final java.util.Set<java.lang.Integer> enableSensorTypes;
property public final int signalsPerSecond;
}

public static final class SensorOptions.Builder {
ctor public SensorOptions.Builder();
method public com.mapbox.navigation.core.sensors.SensorOptions build();
method public com.mapbox.navigation.core.sensors.SensorOptions.Builder enableSensorTypes(java.util.Set<java.lang.Integer> sensorTypes);
method public com.mapbox.navigation.core.sensors.SensorOptions.Builder signalsPerSecond(int signalsPerSecond);
}

}

package com.mapbox.navigation.core.telemetry {

public final class MapboxNavigationTelemetryKt {
Expand Down Expand Up @@ -761,10 +733,6 @@ package com.mapbox.navigation.core.trip.session {
method public void onRouteProgressChanged(com.mapbox.navigation.base.trip.model.RouteProgress routeProgress);
}

public fun interface SensorEventUpdatedCallback {
method public void onSensorEventUpdated(boolean updated);
}

public enum TripSessionState {
enum_constant public static final com.mapbox.navigation.core.trip.session.TripSessionState STARTED;
enum_constant public static final com.mapbox.navigation.core.trip.session.TripSessionState STOPPED;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ package com.mapbox.navigation.core
import android.Manifest.permission.ACCESS_COARSE_LOCATION
import android.Manifest.permission.ACCESS_FINE_LOCATION
import android.content.Context
import android.hardware.SensorEvent
import androidx.annotation.RequiresPermission
import androidx.annotation.UiThread
import com.mapbox.android.core.location.LocationEngine
Expand Down Expand Up @@ -79,7 +78,6 @@ import com.mapbox.navigation.core.trip.session.NavigationSessionStateObserver
import com.mapbox.navigation.core.trip.session.OffRouteObserver
import com.mapbox.navigation.core.trip.session.RoadObjectsOnRouteObserver
import com.mapbox.navigation.core.trip.session.RouteProgressObserver
import com.mapbox.navigation.core.trip.session.SensorEventUpdatedCallback
import com.mapbox.navigation.core.trip.session.TripSession
import com.mapbox.navigation.core.trip.session.TripSessionLocationEngine
import com.mapbox.navigation.core.trip.session.TripSessionState
Expand Down Expand Up @@ -1278,15 +1276,6 @@ class MapboxNavigation(
}
}

/**
* Sends an event to improve navigation positioning. See SensorEventEmitter to register
*
* @param sensorEvent the Android sensor event, it will be ignored if it is not recognized
*/
fun updateSensorEvent(sensorEvent: SensorEvent, callback: SensorEventUpdatedCallback) {
tripSession.updateSensorEvent(sensorEvent, callback)
}

private fun createTilesConfig(
isFallback: Boolean,
tilesVersion: String
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.mapbox.navigation.core.trip.session

import android.hardware.SensorEvent
import android.location.Location
import androidx.annotation.VisibleForTesting
import com.mapbox.api.directions.v5.models.BannerInstructions
Expand All @@ -24,7 +23,6 @@ import com.mapbox.navigation.core.navigator.mapToDirectionsApi
import com.mapbox.navigation.core.navigator.toFixLocation
import com.mapbox.navigation.core.navigator.toLocation
import com.mapbox.navigation.core.navigator.toLocations
import com.mapbox.navigation.core.sensors.SensorMapper
import com.mapbox.navigation.core.trip.service.TripService
import com.mapbox.navigation.core.trip.session.eh.EHorizonObserver
import com.mapbox.navigation.core.trip.session.eh.EHorizonSubscriptionManager
Expand Down Expand Up @@ -504,22 +502,6 @@ internal class MapboxTripSession(
voiceInstructionsObservers.clear()
}

/**
* Sensor event consumed by native
*/
override fun updateSensorEvent(sensorEvent: SensorEvent, callback: SensorEventUpdatedCallback) {
mainJobController.scope.launch {
var sensorUpdated = false
try {
SensorMapper.toSensorData(sensorEvent, logger)?.let { it ->
sensorUpdated = navigator.updateSensorData(it)
}
} finally {
callback.onSensorEventUpdated(sensorUpdated)
}
}
}

/**
* Follows a new leg of the already loaded directions.
* Returns an initialized navigation status if no errors occurred
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.mapbox.navigation.core.trip.session

import android.hardware.SensorEvent
import android.location.Location
import com.mapbox.api.directions.v5.models.DirectionsRoute
import com.mapbox.navigation.base.trip.model.RouteProgress
Expand Down Expand Up @@ -52,7 +51,6 @@ internal interface TripSession {
fun unregisterVoiceInstructionsObserver(voiceInstructionsObserver: VoiceInstructionsObserver)
fun unregisterAllVoiceInstructionsObservers()

fun updateSensorEvent(sensorEvent: SensorEvent, callback: SensorEventUpdatedCallback)
fun updateLegIndex(legIndex: Int, callback: LegIndexUpdatedCallback)

fun registerRoadObjectsOnRouteObserver(
Expand Down
Loading

0 comments on commit 5d5117e

Please sign in to comment.