121 Bugfix properly combine multilinestring multipolygon when zipping #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahalota
force-pushed
the
bugfix-properly-combine-multilinestring-multipolygon
branch
from
e324dd7 to
5bc30be
Compare
ahalota
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #121
Zip currently iterates through point, linestring, multilinestring, polygon, multipolygon and outputs them with one file each named as point, polyline, or polygon. (5 total, 3 unique names)
This causes an issue if you have linestring+multilinestring or polygon+multipolygon. They end up in separate files, but with the same file name, so they overwrite each other in the output and you lose one of them.
This change instead combines them into a single file. For shapefiles, which do not differentiate in file type for linestring/multilinestring or polygon/multipolygon, this makes sense.
The output after this change will produce at most 3 different files in the zip: one for point, one for line+multilinestring, one for polygon+multipolygon.
Note: this does not address multipoints, which are currently not handled properly by the library either.