chore(ci): add an autofix for cargo-sort #2501
Open
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds automated cargo-sort formatting for Cargo.toml files by integrating it into the CI workflow and creating a new autofix job that runs on pull requests.
Changes:
- Replaced
cargo-binstallwithcargo-sortin the CI workflow tool installation - Added a new
fmt-tomljob to the autofix workflow that automatically formats Cargo.toml files - Updated the autofix workflow to trigger on PR opened, synchronize, and reopened events
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Replaced cargo-binstall with cargo-sort in tool installation |
| .github/workflows/autofix.yml | Added fmt-toml job for automatic Cargo.toml formatting and updated trigger conditions |
nyurik
approved these changes
Jan 16, 2026
Member
nyurik
left a comment
nyurik
left a comment
There was a problem hiding this comment.
approving, but plz review the comment first
.github/workflows/ci.yml
Outdated
| - uses: taiki-e/install-action@763e3324d4fd026c9bd284c504378585777a87d5 # v2.62.57 | ||
| # TODO: add cargo-sort once https://github.com/taiki-e/install-action/pull/997 is resolved | ||
| with: { tool: 'just,cargo-binstall' } | ||
| with: { tool: 'just,cargo-sort' } |
Member
There was a problem hiding this comment.
did you mean to remove cargo-sort instead?
Member
Author
There was a problem hiding this comment.
fair, does not make sense to have this in two places
nyurik
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consistently have the problem to get my ABC into check.
I would like to have an autofix for this, but pre-commit does not support running this, so I added it to our autofix config.