feat(rendering): add static map overlay endpoint#2794
Draft
CommanderStorm wants to merge 55 commits into
Draft
Conversation
CommanderStorm
commented
May 9, 2026
Performance Comparison
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds static map rendering capabilities to Martin’s Linux-only rendering feature by introducing /style/{id}/static/... endpoints that render an image via maplibre-native and then draw optional path/marker overlays using tiny-skia. This also updates configuration + schema generation to include the new rendering surface area.
Changes:
- Add
GET/POST /style/{style_id}/static/{static_params}/{size_fmt}endpoints with query/body overlay parameters and image encoding. - Introduce overlay parsing/projection/bounds + drawing modules and add E2E/snapshot-style tests.
- Add a static render pool in
martin-coreand update OpenAPI/config schemas + docs to include rendering config/routes.
Reviewed changes
Copilot reviewed 20 out of 46 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| schemas/openapi.json | Documents new style rendering + static map endpoints and overlay schema. |
| schemas/config.json | Adds styles.rendering configuration schema (bool-or-object). |
| martin/tests/styles_server_test.rs | Adds E2E pixel-matching tests for the static endpoint and overlays. |
| martin/src/srv/styles_static.rs | Implements static map endpoints, request parsing/validation, overlay merge, and encoding. |
| martin/src/srv/styles_rendering.rs | Adjusts schema param handling for rendered tile endpoint. |
| martin/src/srv/static_overlay/project.rs | Adds Web Mercator projection helpers for overlay placement. |
| martin/src/srv/static_overlay/parse.rs | Adds parsers for path, marker, and paint/line style params. |
| martin/src/srv/static_overlay/mod.rs | Defines overlay types, defaults, and exports helpers. |
| martin/src/srv/static_overlay/draw.rs | Implements tiny-skia overlay drawing and snapshot tests. |
| martin/src/srv/static_overlay/bounds.rs | Computes overlay bounds and derives camera framing for auto mode. |
| martin/src/srv/server.rs | Registers static endpoints before the rendered-tile route to avoid routing conflicts. |
| martin/src/srv/mod.rs | Wires in styles_static and static_overlay under rendering (Linux-only). |
| martin/src/schemas.rs | Ensures rendering OpenAPI derive includes the new static endpoints. |
| martin/Cargo.toml | Extends rendering feature deps to include overlay/encoding dependencies and test deps. |
| martin-core/src/resources/styles/static_render_pool.rs | Adds a global single-worker static render pool with renderer/style caching. |
| martin-core/src/resources/styles/mod.rs | Exposes render_static and StaticRenderParams behind rendering (Linux-only). |
| martin-core/src/resources/styles/error.rs | Extends StyleError to include static render pool errors. |
| justfile | Updates gen-schemas to include rendering routes on Linux and sets MLN_PRECOMPILE=1. |
| docs/content/files/generated_config.md | Documents styles.rendering config in generated docs. |
| Cargo.toml | Adds workspace deps for overlay/rendering support crates. |
| Cargo.lock | Updates lockfile for new dependencies and version resolutions. |
CommanderStorm
force-pushed
the
static-rendering-squashed
branch
from
283adf9 to
1bf0a66
Compare
CommanderStorm
changed the title
nyurik
reviewed
May 14, 2026
nyurik
left a comment
nyurik
left a comment
Member
There was a problem hiding this comment.
this is huge! And unlike experimental MLT, this is for a production system... can we somehow break it into smaller chunks?
Bigger issues:
- lots of dup code - ai was going all out on that
- is there a full doc on all functionality? I'm not yet convinced google polyline is the right approach
- should we support geojson with styling approach as used in https://geojson.io/next -- this would be far cleaner imo, rather than reinventing this language
Also, is this all still part of experimental, or is this built by default?
Member
Author
It is not reinventing a language. The entire API is modeled off what seems to work already. I have not heard of the simplestyle apprach, that is one alternative of doing it, but an editor comes later for this. |
CommanderStorm
force-pushed
the
static-rendering-squashed
branch
2 times, most recently
from
3243bea to
ce1894a
Compare
CommanderStorm
force-pushed
the
static-rendering-squashed
branch
7 times, most recently
from
d45545f to
6ad6337
Compare
CommanderStorm
force-pushed
the
static-rendering-squashed
branch
from
7106ff4 to
6804e09
Compare
…uashed # Conflicts: # Cargo.toml # martin-core/Cargo.toml # martin-core/src/resources/styles/mod.rs # martin-core/src/resources/styles/render_pool.rs # martin/src/config/file/error.rs # martin/src/config/file/resources/styles.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new HTTP endpoints under our rendering feature:
POST /style/{id}/static/{camera}/{wxh.fmt}-> render a static map image at a center point, bounding box, or auto-fit to overlays.static_overlaymodule then draws withtiny-skiaover the rendered map.