Make mapContentInset environment value public#143
Merged
Conversation
hactar
requested review from
Archdoog and
ianthetechie
and removed request for
Archdoog
Archdoog
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue/Motivation
Exposes the mapContentInset environment variable, so that Views such as the ones Ferrostar creates can read them in and apply them selectively. I'm creating a PR for Ferrostar which allows users to set the .mapContentInset on the Ferrostar view, so that the inset is applied when not navigating, while ferrostar applies its own when navigation is taking place. Example usage: stadiamaps/ferrostar#872
Alternatively we could of course create a ferrostar specific override, but I think this solution is cleaner and could be a way of allowing people to control ferrostars non navigation behavior for other modifiers too if we like this pattern.