Skip to content

Add first version of first set of MeSH mappings #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

rays22
Copy link
Collaborator

@rays22 rays22 commented Mar 26, 2025

This PR intends to add the first set of OBO Ontology (CL, UBERON, GO, OBA) term mappings to a set of MeSH terms.

This PR intends to add the first set of OBO Ontology (CL, UBERON, GO, OBA) term mappings to a set of MeSH terms.
@rays22 rays22 self-assigned this Mar 26, 2025
@rays22 rays22 requested a review from jamesamcl March 26, 2025 17:41
@jamesamcl
Copy link
Member

jamesamcl commented Mar 27, 2025

Thanks @rays22 -

My initial comments:

  • We should be using skos:exactMatch as with other sssom mapping sets rather than owl:equivalentClass
  • Labels are missing from the tsv which makes this difficult to check
  • Yaml header is missing from the tsv
  • Other metadata also missing; e.g. were these all manual curation?
  • Related to above, where do the confidence scores come from?

@jamesamcl
Copy link
Member

@matentzn would welcome your feedback too

@rays22
Copy link
Collaborator Author

rays22 commented Mar 27, 2025

  • We should be using skos:exactMatch as with other sssom mapping sets rather than owl:equivalentClass
  • Labels are missing from the tsv which makes this difficult to check
  • Other metadata also missing; e.g. were these all manual curation?
  • Related to above, where do the confidence scores come from?

@jamesamcl ,
The mp_hp_example* files that use owl:equivalentClass had been automatically created by the mapping-commons github template when I created the repo. I will remove them.

I will investigate this:

  • Yaml header is missing from the tsv

@rays22
Copy link
Collaborator Author

rays22 commented Apr 2, 2025

rays22 added 3 commits April 7, 2025 15:59
This commit intends to
1. update some of the mappings, and
2. add new MeSH Concept term mappings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants