Automatic handling for -D_Bool=bool where required #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mappu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #102
Updates: #73
Some platforms using a new version of Clang seem to require
-D_Bool=boolin the CGO_CXXFLAGS. Replace this with an#ifndef _Bool ; #define _Bool boolin the .cpp files directly.The issue is caused because Miqt needs to import Cgo's generated C file, which uses the C-specific _Bool type, which is not defined in the C++ standard.
There exists
stdbool.h/cstdboolfor C users, to define bool in terms of _Bool, but Miqt needs the opposite.Presumably this used to work on older Clang and works on GCC because of a different (less strict?) set of standard definitions.
Reviewed-By: @FalcoG in #102 (comment)