Use aqt for genbindings #156

Ahuge · 2025-01-31T04:44:35Z

This PR starts to switch to using aqt to target specific versions of Qt instead of relying on the version the distro provides

Ahuge · 2025-01-31T04:59:43Z

Currently getting numeric_limits errors

Not sure if that is related to my changes or not. I'll run some tests without my changes as well

error: no member named 'numeric_limits' in namespace 'std'

docker run --user $(id -u):$(id -g) -v ~/.cache/go-build:/.cache/go-build -v $PWD:/src -w /src miqt/genbindings:latest /bin/bash -c 'cd cmd/genbindings && go build && ./genbindings'
Found 577 header files to process.
Cleaning up output directory "../../qt"...
Removed 0 file(s).
Clang worker: starting
Clang worker: starting
No AST cache for file "qbytearraymatcher.h", running clang...
Clang worker got message for file "/opt/Qt/5.15.2/gcc_64/include/QtCore/qbytearraymatcher.h"
No AST cache for file "qendian.h", running clang...
Clang worker got message for file "/opt/Qt/5.15.2/gcc_64/include/QtCore/qendian.h"
No AST cache for file "qeventloop.h", running clang...
/opt/Qt/5.15.2/gcc_64/include/QtCore/qbytearraymatcher.h:103:38: error: no member named 'numeric_limits' in namespace 'std'
        const auto uchar_max = (std::numeric_limits<uchar>::max)();
                                ~~~~~^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qbytearraymatcher.h:103:53: error: unexpected type name 'uchar': expected expression
        const auto uchar_max = (std::numeric_limits<uchar>::max)();
                                                    ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qbytearraymatcher.h:103:59: error: no member named 'max' in the global namespace; did you mean 'std::max'?
        const auto uchar_max = (std::numeric_limits<uchar>::max)();
                                                          ^~~~~
                                                          std::max
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/algorithmfwd.h:407:5: note: 'std::max' declared here
    max(const _Tp&, const _Tp&);
    ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qbytearraymatcher.h:103:20: warning: uninitialized variable in a constexpr function is a C++20 extension [-Wc++20-extensions]
        const auto uchar_max = (std::numeric_limits<uchar>::max)();
                   ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qbytearraymatcher.h:104:15: warning: uninitialized variable in a constexpr function is a C++20 extension [-Wc++20-extensions]
        uchar max = n > uchar_max ? uchar_max : n;
              ^
In file included from /opt/Qt/5.15.2/gcc_64/include/QtCore/qendian.h:44:
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:300:7: error: explicit specialization of undeclared template class 'numeric_limits'
class numeric_limits<QT_PREPEND_NAMESPACE(qfloat16)> : public numeric_limits<float>
      ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:300:63: error: unknown template name 'numeric_limits'
class numeric_limits<QT_PREPEND_NAMESPACE(qfloat16)> : public numeric_limits<float>
                                                              ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:344:18: error: explicit specialization of non-template class 'numeric_limits'
template<> class numeric_limits<const QT_PREPEND_NAMESPACE(qfloat16)>
                 ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:344:18: error: redefinition of 'numeric_limits'
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:300:7: note: previous definition is here
class numeric_limits<QT_PREPEND_NAMESPACE(qfloat16)> : public numeric_limits<float>
      ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:345:14: error: unknown template name 'numeric_limits'
    : public numeric_limits<QT_PREPEND_NAMESPACE(qfloat16)> {};
             ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:346:18: error: explicit specialization of non-template class 'numeric_limits'
template<> class numeric_limits<volatile QT_PREPEND_NAMESPACE(qfloat16)>
                 ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:346:18: error: redefinition of 'numeric_limits'
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:300:7: note: previous definition is here
class numeric_limits<QT_PREPEND_NAMESPACE(qfloat16)> : public numeric_limits<float>
      ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:347:14: error: unknown template name 'numeric_limits'
    : public numeric_limits<QT_PREPEND_NAMESPACE(qfloat16)> {};
             ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:348:18: error: explicit specialization of non-template class 'numeric_limits'
template<> class numeric_limits<const volatile QT_PREPEND_NAMESPACE(qfloat16)>
                 ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:348:18: error: redefinition of 'numeric_limits'
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:300:7: note: previous definition is here
class numeric_limits<QT_PREPEND_NAMESPACE(qfloat16)> : public numeric_limits<float>
      ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qfloat16.h:349:14: error: unknown template name 'numeric_limits'
    : public numeric_limits<QT_PREPEND_NAMESPACE(qfloat16)> {};
             ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qendian.h:331:49: error: expected '(' for function-style cast or type construction
    { return QSpecialInteger(std::numeric_limits<T>::max()); }
                             ~~~~~~~~~~~~~~~~~~~^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qendian.h:331:50: error: unexpected type name 'T': expected expression
    { return QSpecialInteger(std::numeric_limits<T>::max()); }
                                                 ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qendian.h:331:52: error: no member named 'max' in the global namespace; did you mean simply 'max'?
    { return QSpecialInteger(std::numeric_limits<T>::max()); }
                                                   ^~~~~
                                                   max
/opt/Qt/5.15.2/gcc_64/include/QtCore/qendian.h:330:45: note: 'max' declared here
    static Q_DECL_CONSTEXPR QSpecialInteger max()
                                            ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qendian.h:333:49: error: expected '(' for function-style cast or type construction
    { return QSpecialInteger(std::numeric_limits<T>::min()); }
                             ~~~~~~~~~~~~~~~~~~~^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qendian.h:333:50: error: unexpected type name 'T': expected expression
    { return QSpecialInteger(std::numeric_limits<T>::min()); }
                                                 ^
/opt/Qt/5.15.2/gcc_64/include/QtCore/qendian.h:333:52: error: no member named 'min' in the global namespace; did you mean simply 'min'?
    { return QSpecialInteger(std::numeric_limits<T>::min()); }
                                                   ^~~~~
                                                   min
/opt/Qt/5.15.2/gcc_64/include/QtCore/qendian.h:332:45: note: 'min' declared here
    static Q_DECL_CONSTEXPR QSpecialInteger min()
                                            ^
2 warnings and 3 errors generated.
WARNING: Clang execution failed: Command: exit status 1
17 errors generated.
WARNING: Clang execution failed: Command: exit status 1

ddkwork · 2025-01-31T07:15:18Z

nice work, please test build apk

Ahuge · 2025-01-31T16:46:32Z

Those errors do appear to be related to the aqt build. I don't get them with the standard docker image.

:/

I need to figure out what the cause of this error is:

/opt/Qt/5.15.2/gcc_64/include/QtCore/qbytearraymatcher.h:103:38: error: no member named 'numeric_limits' in namespace 'std'
        const auto uchar_max = (std::numeric_limits<uchar>::max)();

Ahuge · 2025-01-31T22:06:44Z

Ah
https://salsa.debian.org/qt-kde-team/qt/qtbase/-/blob/debian/5.15.2+dfsg-15/debian/patches/gcc_11_limits.diff?ref_type=tags

So it looks like the builds that Debian provide have patched headers and source files.

arnetheduck · 2025-01-31T22:23:58Z

qt5.15.18 is out, why are you targeting .2?

mappu · 2025-01-31T22:43:27Z

docker/genbindings.Dockerfile

+ENV PATH=/opt/Qt/$QT6_VERSION/gcc_64/bin:$PATH
+ENV LD_LIBRARY_PATH=/opt/Qt/$QT6_VERSION/gcc_64/lib
+ENV QT_PLUGIN_PATH=/opt/Qt/$QT6_VERSION/gcc_64/plugins
+ENV QTDIR=/opt/Qt/$QT6_VERSION/gcc_64


Will these declarations overwrite the Qt5 ones? I think they're maybe not needed.

That is a good point.
They will be overriding the Qt5 ones.
We will likely need to generate the bindings for each major version in a separate step?

The LD_LIBRARY_PATH and QT_PLUGIN_PATH are used by Qt apps at runtime to find their needed .so files. The PATH and QTDIR are only needed so that a developer can more easily run qmake.

I think Genbindings doesn't need any of those four, it should only need the Qt5Root change in config-libraries.go plus the new PKG_CONFIG_PATH entries.

Ahuge · 2025-02-01T00:34:26Z

qt5.15.18 is out, why are you targeting .2?

a

qt5.15.18 is out, why are you targeting .2?

https://download.qt.io/online/qtsdkrepository

The packages are provided by Qt project/The Qt company, not by aqtinstall project.

Ahuge · 2025-02-01T00:34:47Z

The Qt company doesn't have opensource releases for anything newer than 5.15.x

Ahuge · 2025-02-01T01:07:42Z

There may be a route forward, the debian patches are in their got. We could maybe pull down their patches for the release we're building against and apply any patches for headers we parse?

Ahuge · 2025-02-01T01:18:47Z

https://salsa.debian.org/qt-kde-team/qt/qtbase/-/tree/debian/5.15.2+dfsg-15/debian/patches?ref_type=tags

mappu · 2025-02-01T01:21:28Z

Regarding #include <limits>, it was added to upstream Qt in 5.15.3 and later: qt/qtbase@0afad46

To use the 5.15.2 headers, another solution would be to put -include limits in the CFLAGS environment variable, or patch it into the CFLAGS included declared in the Qt5Widgets.pc file.

I think there are Qt 5.15.16 prebuilt binaries available in the https://download.qt.io/archive/qt/5.15/ directory, although they're not separated by target OS, so perhaps aqtinstall can't find them.

Ahuge · 2025-02-03T16:39:13Z

I think there are Qt 5.15.16 prebuilt binaries available in the https://download.qt.io/archive/qt/5.15/ directory, although they're not separated by target OS, so perhaps aqtinstall can't find them.

I think those are all source files actually. Just took a look and it seems like they might be

Ahuge added 3 commits January 30, 2025 20:17

Switch to using aqt for Qt versions

ce7451f

Extract out Qt5 and Qt6 roots

e69b590

Reintroduce the scintilla

9fb58ee

Include directory for Qt5/6 roots

4b747aa

Ahuge marked this pull request as draft January 31, 2025 22:19

mappu reviewed Jan 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use aqt for genbindings #156

Use aqt for genbindings #156

Ahuge commented Jan 31, 2025

Ahuge commented Jan 31, 2025 •

edited

Loading

ddkwork commented Jan 31, 2025

Ahuge commented Jan 31, 2025

Ahuge commented Jan 31, 2025

arnetheduck commented Jan 31, 2025

mappu Jan 31, 2025

Ahuge Feb 1, 2025

mappu Feb 1, 2025

Ahuge commented Feb 1, 2025

Ahuge commented Feb 1, 2025

Ahuge commented Feb 1, 2025

Ahuge commented Feb 1, 2025

mappu commented Feb 1, 2025 •

edited

Loading

Ahuge commented Feb 3, 2025

Use aqt for genbindings #156

Are you sure you want to change the base?

Use aqt for genbindings #156

Conversation

Ahuge commented Jan 31, 2025

Ahuge commented Jan 31, 2025 • edited Loading

ddkwork commented Jan 31, 2025

Ahuge commented Jan 31, 2025

Ahuge commented Jan 31, 2025

arnetheduck commented Jan 31, 2025

mappu Jan 31, 2025

Choose a reason for hiding this comment

Ahuge Feb 1, 2025

Choose a reason for hiding this comment

mappu Feb 1, 2025

Choose a reason for hiding this comment

Ahuge commented Feb 1, 2025

Ahuge commented Feb 1, 2025

Ahuge commented Feb 1, 2025

Ahuge commented Feb 1, 2025

mappu commented Feb 1, 2025 • edited Loading

Ahuge commented Feb 3, 2025

Ahuge commented Jan 31, 2025 •

edited

Loading

mappu commented Feb 1, 2025 •

edited

Loading