Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jsBridge noARC & multiple webViews-compatible, improve interface. #2

Merged

Conversation

psineur
Copy link
Contributor

@psineur psineur commented Oct 27, 2011

Better Interface:

  • Private stuff moved to implementation file.
  • createBridge changed to factory & init methods.

Multiple WebViews:

  • webView property removed.
  • sendMessage:toWebView: instead of sendMessage:
  • _flushMessageQueueFromWebView: instead of _flushMessageQueue

Better Interface:
 * Private stuff moved to implementation file.
 * createBridge changed to factory & init methods.

Multiple WebViews:
 * webView property removed.
 * sendMessage:toWebView: instead of sendMessage:
 * _flushMessageQueueFromWebView: instead of _flushMessageQueue
@marcuswestin
Copy link
Owner

Very nice - will review and pull.

Cheers!

@psineur
Copy link
Contributor Author

psineur commented Oct 31, 2011

Hello again!

There are two new commits above.

I made delegate property public & assign (was retain). It's a common practice in Objective-C to assign delegates instead of retaining them to avoid retain loops.

Also i changed factory & init methods - since they don't need delegate argument anymore.

Last thing is nonatomic properties - if there's no performance issues - it's better to have atomic properties, especially in multithreaded environment.

marcuswestin added a commit that referenced this pull request Nov 4, 2011
Make jsBridge noARC & multiple webViews-compatible, improve interface.
@marcuswestin marcuswestin merged commit 8b1d103 into marcuswestin:master Nov 4, 2011
@marcuswestin
Copy link
Owner

Great stuff - thank you Stepan.

Are you using it?

@psineur
Copy link
Contributor Author

psineur commented Nov 5, 2011

Yes, of course! And it works very good!
Thanks!

@marcuswestin
Copy link
Owner

Will add you to list of contributors. I'm still new to ios development and realize it wasn't a very idiomatic API. Thanks for the cleaning up :)

Mind if I ask what you're using it for?

-- while mobile

On Nov 5, 2011, at 4:32 AM, Stepan [email protected] wrote:

Yes, of course! And it works very good!
Thanks!


Reply to this email directly or view it on GitHub:
#2 (comment)

@psineur
Copy link
Contributor Author

psineur commented Nov 5, 2011

Were building a thin client for web service with web views layout.
Idea is to move all possible content and logic to server.

Best Regards,
Stepan

05.11.2011, в 22:01, Marcus [email protected] написал(а):

Will add you to list of contributors. I'm still new to ios development and realize it wasn't a very idiomatic API. Thanks for the cleaning up :)

Mind if I ask what you're using it for?

-- while mobile

On Nov 5, 2011, at 4:32 AM, Stepan [email protected] wrote:

Yes, of course! And it works very good!
Thanks!


Reply to this email directly or view it on GitHub:
#2 (comment)


Reply to this email directly or view it on GitHub:
#2 (comment)

@marcuswestin
Copy link
Owner

added you to contributors: 4dbb54e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants