-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make jsBridge noARC & multiple webViews-compatible, improve interface. #2
Make jsBridge noARC & multiple webViews-compatible, improve interface. #2
Conversation
Better Interface: * Private stuff moved to implementation file. * createBridge changed to factory & init methods. Multiple WebViews: * webView property removed. * sendMessage:toWebView: instead of sendMessage: * _flushMessageQueueFromWebView: instead of _flushMessageQueue
Very nice - will review and pull. Cheers! |
Also make all properties atomic for thread safety.
Hello again! There are two new commits above. I made delegate property public & assign (was retain). It's a common practice in Objective-C to assign delegates instead of retaining them to avoid retain loops. Also i changed factory & init methods - since they don't need delegate argument anymore. Last thing is nonatomic properties - if there's no performance issues - it's better to have atomic properties, especially in multithreaded environment. |
Make jsBridge noARC & multiple webViews-compatible, improve interface.
Great stuff - thank you Stepan. Are you using it? |
Yes, of course! And it works very good! |
Will add you to list of contributors. I'm still new to ios development and realize it wasn't a very idiomatic API. Thanks for the cleaning up :) Mind if I ask what you're using it for? -- while mobile On Nov 5, 2011, at 4:32 AM, Stepan [email protected] wrote:
|
Were building a thin client for web service with web views layout. Best Regards, 05.11.2011, в 22:01, Marcus [email protected] написал(а):
|
added you to contributors: 4dbb54e |
Better Interface:
Multiple WebViews: