Update phpstan and phpcs (#262)

This allows for new features like property hooks.
marein · Jan 12, 2025 · 7aced33 · 7aced33
1 parent a6375d0
commit 7aced33
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 35 deletions.
diff --git a/composer.json b/composer.json
@@ -25,7 +25,7 @@
     }
   },
   "require": {
-    "php": "^8.3",
+    "php": "^8.4",
     "ext-pcntl": "*",
     "ext-posix": "*",
     "ext-session": "*",
@@ -72,12 +72,12 @@
     "codeception/codeception": "^5.0",
     "codeception/module-asserts": "^3.0",
     "codeception/module-webdriver": "^4.0",
-    "phpstan/extension-installer": "^1.1",
-    "phpstan/phpstan": "^1.8",
-    "phpstan/phpstan-doctrine": "^1.3",
+    "phpstan/extension-installer": "^1.4",
+    "phpstan/phpstan": "^2.1",
+    "phpstan/phpstan-doctrine": "^2.0",
     "phpunit/phpunit": "^10.3",
     "roave/security-advisories": "dev-master",
-    "squizlabs/php_codesniffer": "^3.7",
+    "squizlabs/php_codesniffer": "^3.11",
     "symfony/debug-bundle": "^7.0",
     "symfony/error-handler": "^7.0",
     "symfony/stopwatch": "^7.0",

diff --git a/composer.lock b/composer.lock
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -7,5 +7,5 @@ parameters:
     - message: '#(should return|expects) non-empty-string( but returns string|, string given)\.$#'
     - message: '#^Call to an undefined method Symfony[^:]+::children\(\)\.$#'
     - message: '#^While loop condition is always true\.$#'
-    - message: "#^Property Gaming\\\\Identity\\\\Domain\\\\Model\\\\User\\\\User\\:\\:\\$version is never read, only written\\.$#"
+    - message: "#^Property Gaming\\\\Identity\\\\Domain\\\\Model\\\\User\\\\User\\:\\:\\$version#"
     - message: "#^Property Gaming\\\\Memory\\\\Domain\\\\Model\\\\Game\\\\Game\\:\\:\\$cards is never read, only written\\.$#"
diff --git a/src/Common/DoctrineHeartbeatMiddleware/ConnectionHeartbeatHandler.php b/src/Common/DoctrineHeartbeatMiddleware/ConnectionHeartbeatHandler.php
@@ -36,7 +36,6 @@ public function handle(Scheduler $scheduler): void
         if ($connection === null) {
             return;
         }
-        assert($connection instanceof TrackActivityConnection);
 
         if (
             !$connection->isQuerying()

diff --git a/src/Common/EventStore/Integration/Symfony/CleanUpEventStoreCommand.php b/src/Common/EventStore/Integration/Symfony/CleanUpEventStoreCommand.php
@@ -47,6 +47,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
 
+        /** @var non-empty-array<string, int> $pointers */
         $pointers = [];
         foreach ($input->getArgument('pointers') as $pointer) {
             $pointers[$pointer] = $this->eventStorePointerFactory

diff --git a/src/WebInterface/Infrastructure/Security/ArrivalAuthenticator.php b/src/WebInterface/Infrastructure/Security/ArrivalAuthenticator.php
@@ -24,7 +24,7 @@ public function __construct(
     ) {
     }
 
-    public function supports(Request $request): ?bool
+    public function supports(Request $request): bool
     {
         /**
          * A better idea would be to authenticate an anonymous user only when needed.
-Original file line number
+Diff line change
@@ Expand Up / @@ -36,7 +36,6 @@ public function handle(Scheduler $scheduler): void @@
             if ($connection === null) {
                 return;
             }
-            assert($connection instanceof TrackActivityConnection);
             if (
                 !$connection->isQuerying()
@@ Expand Down @@