Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow players to choose game configuration #260

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Allow players to choose game configuration #260

wants to merge 9 commits into from

Conversation

marein
Copy link
Owner

@marein marein commented Dec 4, 2024 •
edited
Loading

This pull requests partially introduces a new concept, the challenge - described in #123, for views. It's not introducing the whole concept explicitly, otherwise the pull request would be too big.

@marein marein self-assigned this Dec 4, 2024
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch 28 times, most recently from c273bce to 1742016 Compare December 7, 2024 07:49
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch 3 times, most recently from 3826e1f to f625ae7 Compare December 14, 2024 22:49
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch from f625ae7 to 26f1bfc Compare January 11, 2025 11:16
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch from 26f1bfc to 778beb6 Compare January 12, 2025 12:31
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch 3 times, most recently from 929c7bc to 6f5354d Compare January 25, 2025 07:38
@marein marein linked an issue Feb 25, 2025 that may be closed by this pull request
Allow players to choose game configuration #259
Open
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch from 6f5354d to b944aad Compare February 25, 2025 20:34
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch from b944aad to 9b8f4ba Compare February 28, 2025 20:42
marein
marein commented Mar 2, 2025
View reviewed changes
config/connect-four/services/controller.yml

connect-four.page-controller:
class: Gaming\ConnectFour\Port\Adapter\Http\PageController
arguments: ['@connect-four.command-bus', '@connect-four.query-bus', '@web-interface.security']
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency to WebInterface should be reconsidered (also within the templates).

@marein marein mentioned this pull request Mar 2, 2025
Merged
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch from 8adc8ce to 82862df Compare March 2, 2025 15:57
marein added 2 commits March 2, 2025 20:15
@marein
Revert refactorings
c3dce10 
They can be done later, this work is already pretty big.

Also, adjust preconfigured sizes to match the aspect ratio.
@marein
Abort challenge does not use json
b74ac51
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch from 3d882ad to 05e7065 Compare March 3, 2025 11:49
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch from 05e7065 to d57c046 Compare March 3, 2025 11:59
@marein marein force-pushed the 259-allow-players-to-choose-game-configuration branch from ab9840b to 4f3b7e4 Compare March 3, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@marein marein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow players to choose game configuration
1 participant
@marein