MDEV-36677: wsrep_sst_rsync broken if innodb_log_group_home_dir is different than datadir - #543
Open
plampio wants to merge 3 commits into
Open
MDEV-36677: wsrep_sst_rsync broken if innodb_log_group_home_dir is different than datadir#543plampio wants to merge 3 commits into
plampio wants to merge 3 commits into
Conversation
…fferent
than datadir
This patch adds a new MTR test "galera.galera_mdev_36677" to check
that the rsync SST method of Galera works correctly also when
the joiner node store InnoDB log files in a dedicated directory
separate from the data dictionary.
…side the data directory. Extended MTR test coverage and replaced MTR test galera.galera_mdev_36677 with galera_3nodes.galera_mdev_36677.
janlindstrom
approved these changes
Nov 7, 2025
janlindstrom
left a comment
janlindstrom
left a comment
There was a problem hiding this comment.
LGTM.
Is 11.4 really lowest version where this is a problem? Please test testcase on 10.11 if innodb_log_group_home_dir can be something else than datadir.
|
10.11.10+ has same problem
|
sjaakola
added a commit
to MariaDB/server
that referenced
this pull request
Aug 7, 2026
…nd datadir Backported the fix done by Pekka Lampio for mariaDB 11.4 in PR mariadb-corporation#543 The PR has a fix for wsrep_sst_rsync script and new mtr test: galera_3nodes.galera_mdev_36677" to check that the rsync SST method of Galera works correctly also when the joiner node store InnoDB log files in a dedicated directory separate from the data dictionary Note: merging this PR to 11.4 may not be fully functional as there are other changes in the rsync SST script. Take a look at the original 11.4 PR when merging.
sjaakola
added a commit
to MariaDB/server
that referenced
this pull request
Aug 11, 2026
…nd datadir Backported the fix done by Pekka Lampio for mariaDB 11.4 in PR mariadb-corporation#543 The PR has a fix for wsrep_sst_rsync script and new mtr test: galera_3nodes.galera_mdev_36677" to check that the rsync SST method of Galera works correctly also when the joiner node store InnoDB log files in a dedicated directory separate from the data dictionary Note: merging this PR to 11.4 may not be fully functional as there are other changes in the rsync SST script. Take a look at the original 11.4 PR when merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rsync SST method of Galera worked incorrectly if
innodb_log_group_home_diroraria_log_dir_pathwere not the same asdatadirat the SST donor node. This patch fixes the brokenwsrep_sst_rsyncshell script.This patch adds a new MTR test
galera_3nodes.galera_mdev_36677to check that the rsync SST method of Galera works correctly also when the donor node stores InnoDB and Aria log files in a dedicated directory separate from the data directory.