[iris] Preserve adopted task host-port reservations across worker restart#6723
Merged
Conversation
…tart
On worker restart, an adopted container's host ports were dropped: adopt()
rebuilt ports={} and never re-marked the PortAllocator, so the worker could
re-hand those ports to a new task and cause a bind clash.
Stamp the allocated ports as an iris.ports Docker label, recover them into
DiscoveredContainer during discovery, and have adopt() restore attempt.ports
and reserve() them on the allocator before scheduling new work.
Fixes #6721
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On worker restart an adopted container kept running but its host-port reservations were lost: TaskAttempt.adopt() rebuilt ports={} and never re-marked the PortAllocator, which started empty. The worker could then re-hand those in-use ports (e.g. 30000/30001) to the next scheduled task, causing a bind clash.
The port set had no substrate footprint, so it could not be recovered. This change gives it one and restores it on adopt:
Independent of multi-backend, and a prerequisite for the per-cluster agent recoverable-cache port recovery in #6718.
Fixes #6721