refine error message

marin-ma · Nov 28, 2024 · 732c5b0 · 732c5b0
1 parent 2cc9608
commit 732c5b0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/velox/common/compression/Compression.cpp b/velox/common/compression/Compression.cpp
@@ -134,8 +134,9 @@ Expected<std::unique_ptr<Codec>> Codec::create(
       return folly::makeUnexpected(
           Status::Invalid("Unrecognized codec '{}'", name));
     }
-    return folly::makeUnexpected(
-        Status::Invalid("Support for codec '{}' not implemented.", name));
+    return folly::makeUnexpected(Status::Invalid(
+        "Support for codec '{}' is either not built or not implemented.",
+        name));
   }
 
   auto compressionLevel = codecOptions.compressionLevel;
@@ -166,7 +167,7 @@ Expected<std::unique_ptr<Codec>> Codec::create(
 
   if (codec == nullptr) {
     return folly::makeUnexpected(Status::Invalid(
-        "Support for codec '{}' not implemented.",
+        "Support for codec '{}' is either not built or not implemented.",
         compressionKindToString(kind)));
   }
 

diff --git a/velox/common/compression/tests/CompressionTest.cpp b/velox/common/compression/tests/CompressionTest.cpp
@@ -371,7 +371,7 @@ TEST_P(CodecTest, specifyCompressionLevel) {
     VELOX_ASSERT_THROW(
         Codec::create(kind, kUseDefaultCompressionLevel),
         "Support for codec '" + compressionKindToString(kind) +
-            "' not implemented.");
+            "' is either not built or not implemented.");
     return;
   }
   auto codecDefault = Codec::create(kind).thenOrThrow(folly::identity);