Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Sep 24, 2025

Release notes indicate this should be safe, and Copilot was in favor of it as well as a way of minimizing CVEs.

Also fixed a typo in the SSL class.

Release notes indicate this should be safe, and Copilot was in favor of it as well as a way of minimizing CVEs.

Also fixed a typo in the SSL class.
@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 15:11
Copy link

Copyright Validation Results
Total: 4 | Passed: 1 | Failed: 0 | Skipped: 3 | at: 2025-09-24 15:11:38 UTC | commit: 4a04d26

⏭️ Skipped (Excluded) Files

  • build.gradle
  • flux-cli/build.gradle
  • gradle.properties

✅ Valid Files

  • flux-cli/src/test/java/com/marklogic/flux/junit5/TwoWaySslConfigurer.java

✅ All files have valid copyright headers!

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades Hadoop from version 3.4.1 to 3.4.2 to incorporate latest security fixes and bug patches while maintaining compatibility with Spark 4.0.1.

  • Bumped Hadoop version from 3.4.1 to 3.4.2 in gradle.properties
  • Updated AWS SDK s3-transfer-manager dependency to align with Hadoop 3.4.2's requirements
  • Fixed a syntax error in XQuery string formatting within SSL test configuration

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
gradle.properties Updated Hadoop version to 3.4.2 with explanatory comment
flux-cli/build.gradle Aligned AWS SDK s3-transfer-manager version with Hadoop 3.4.2 dependency
flux-cli/src/test/java/com/marklogic/flux/junit5/TwoWaySslConfigurer.java Fixed XQuery syntax error in string formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

import module namespace pki = "http://marklogic.com/xdmp/pki" at "/MarkLogic/pki.xqy
pki:delete-authority("%s")", certificateAuthorityName)""".formatted(certificateAuthorityName);
import module namespace pki = 'http://marklogic.com/xdmp/pki' at '/MarkLogic/pki.xqy';
pki:delete-authority('%s')""".formatted(certificateAuthorityName);
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XQuery string has mismatched quotes and missing semicolon. The original code had an unclosed double quote in the import statement and incorrect string formatting syntax. The fix correctly uses single quotes throughout and adds the missing semicolon after the import statement.

Suggested change
pki:delete-authority('%s')""".formatted(certificateAuthorityName);
pki:delete-authority('%s');
""".formatted(certificateAuthorityName);

Copilot uses AI. Check for mistakes.

@rjrudin rjrudin merged commit c076d4a into develop Sep 24, 2025
2 checks passed
@rjrudin rjrudin deleted the feature/bump-dependencies branch September 24, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant