MLE-23024 Excluding Jetty and more dependency bumps #478
Conversation
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR excludes Jetty dependencies to address medium-severity CVEs and updates several dependency versions. The changes disable the Spark UI to prevent Jetty from being used since there's no current use case for the UI in Flux applications.
- Disabled Spark UI to avoid Jetty dependency usage
- Updated test dependencies (json-unit-assertj and xmlunit-core) to newer patch versions
- Upgraded ml-gradle plugin from version 5.0.0 to 6.0.1
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flux-cli/src/main/java/com/marklogic/flux/impl/SparkUtil.java | Added configuration to disable Spark UI with explanatory comment |
| flux-cli/build.gradle | Updated json-unit-assertj and xmlunit-core test dependencies to newer versions |
| examples/getting-started/build.gradle | Upgraded ml-gradle plugin version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| sparkConf.set("spark.sql.session.timeZone", "UTC"); | ||
|
|
||
| // To avoid the need for Jetty on the classpath, which brings in a number of medium CVEs (as Spark 4 is using | ||
| // Jetty 9), the Spark UI is explicitly disabled. Curiously, this doesn't seem to be required - i.e. when |
There was a problem hiding this comment.
There's an extra space in 'Spark UI is' - should be 'Spark UI is' with only one space.
| // Jetty 9), the Spark UI is explicitly disabled. Curiously, this doesn't seem to be required - i.e. when | |
| // Jetty 9), the Spark UI is explicitly disabled. Curiously, this doesn't seem to be required - i.e. when |
Copilot uses AI. Check for mistakes.
|
|
||
| // To avoid the need for Jetty on the classpath, which brings in a number of medium CVEs (as Spark 4 is using | ||
| // Jetty 9), the Spark UI is explicitly disabled. Curiously, this doesn't seem to be required - i.e. when | ||
| // excluding org.eclipse.jetty libaries from the classpath, no failures occur. But this is being done to |
There was a problem hiding this comment.
Typo in 'libaries' - should be 'libraries'.
| // excluding org.eclipse.jetty libaries from the classpath, no failures occur. But this is being done to | |
| // excluding org.eclipse.jetty libraries from the classpath, no failures occur. But this is being done to |
Copilot uses AI. Check for mistakes.
rjrudin
force-pushed
the
feature/more-bumps
branch
from
1209804 to
a4617bc
Compare
2 participants
No description provided.