Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Sep 26, 2025

No longer need "AbstractJava17Test"

No longer need "AbstractJava17Test"
@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 15:47
Copy link

Copyright Validation Results
Total: 7 | Passed: 7 | Failed: 0 | Skipped: 0 | at: 2025-09-26 15:48:00 UTC | commit: f3613c4

✅ Valid Files

  • flux-cli/src/test/java/com/marklogic/flux/AbstractTest.java
  • flux-cli/src/test/java/com/marklogic/flux/api/SplitWithApiTest.java
  • flux-cli/src/test/java/com/marklogic/flux/impl/importdata/ImportAndSplitFilesTest.java
  • flux-cli/src/test/java/com/marklogic/flux/impl/importdata/ImportFilesWithEmbedderTest.java
  • flux-cli/src/test/java/com/marklogic/flux/impl/importdata/ImportWithAllProcessingTest.java
  • flux-cli/src/test/java/com/marklogic/flux/impl/importdata/SplitterSmokeTest.java
  • flux-cli/src/test/java/com/marklogic/flux/tde/AbstractTdeTest.java

✅ All files have valid copyright headers!

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates the test class hierarchy by removing the intermediate AbstractJava17Test class and moving its functionality directly into AbstractTest. All test classes that previously extended AbstractJava17Test now extend AbstractTest directly.

  • Removed the AbstractJava17Test class as it's no longer needed
  • Consolidated test base class functionality into AbstractTest
  • Updated all test classes to extend AbstractTest instead of AbstractJava17Test

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
AbstractTest.java Expanded to include all functionality from both AbstractFluxTest and AbstractJava17Test
AbstractJava17Test.java Removed entirely as it's no longer needed
AbstractFluxTest.java Removed entirely, functionality moved to AbstractTest
AbstractTdeTest.java Updated import and inheritance to use AbstractTest
SplitterSmokeTest.java Updated import and inheritance to use AbstractTest
ImportWithAllProcessingTest.java Updated import and inheritance to use AbstractTest
ImportFilesWithEmbedderTest.java Updated imports, inheritance, and constant references to use AbstractTest
ImportAndSplitFilesTest.java Updated imports, inheritance, and constant references to use AbstractTest
SplitWithApiTest.java Updated import and inheritance to use AbstractTest

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rjrudin rjrudin merged commit 6f6cf28 into develop Sep 26, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/test-cleanup branch September 26, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant