Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Sep 29, 2025

Sigh, turns out we still need these on Windows.

@Copilot Copilot AI review requested due to automatic review settings September 29, 2025 16:56
Copy link

github-actions bot commented Sep 29, 2025

Copyright Validation Results
Total: 8 | Passed: 0 | Failed: 0 | Skipped: 8 | at: 2025-09-29 17:03:14 UTC | commit: a88fbd2

⏭️ Skipped (Excluded) Files

  • .copyrightconfig
  • flux-cli/build.gradle
  • flux-cli/hadoop/README.txt
  • flux-cli/hadoop/hadoop.dll
  • flux-cli/hadoop/libhadoop.so
  • flux-cli/hadoop/msvcr100.dll
  • flux-cli/hadoop/msvcr120.dll
  • flux-cli/hadoop/winutils.exe

✅ All files have valid copyright headers!

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores Hadoop native library files that are required for Flux to run on Windows. The files were previously removed but testing has shown they are still necessary for Windows compatibility.

  • Adds back 5 Hadoop native files (DLLs and executables) needed for Windows operation
  • Includes documentation explaining the rationale for these files and their continued necessity

Reviewed Changes

Copilot reviewed 2 out of 7 changed files in this pull request and generated 1 comment.

File Description
flux-cli/hadoop/README.txt Documentation explaining which Hadoop files are included and why they're needed for Windows compatibility
flux-cli/build.gradle Build configuration to include Hadoop native libraries in the distribution packages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

haven't covered the need for those 5 files.

As of Spark 4.1.0-preview1 - the hadoop.dll and msvcr100.dll files are still needed when running Flux on Windows. The
other files are still being retained just in case.
Copy link

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space at the end of line 6. Remove the trailing whitespace.

Suggested change
other files are still being retained just in case.
other files are still being retained just in case.

Copilot uses AI. Check for mistakes.

Sigh, turns out we still need these on Windows.
@rjrudin rjrudin force-pushed the feature/bring-hadoop-files-back branch from a019656 to a88fbd2 Compare September 29, 2025 17:02
@rjrudin rjrudin merged commit 17d6f53 into develop Sep 29, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/bring-hadoop-files-back branch September 29, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant