MLE-24717 Bumped logback and Java Client #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some Gradle warnings too. And removed OBE shadowing of okhttp as Spark 4 does not depend on okhttp.
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
There was a problem hiding this comment.
Pull Request Overview
Updates third-party dependency versions and removes obsolete build configuration for Spark 4 compatibility. The changes focus on bumping logback from 1.5.18 to 1.5.19 and upgrading the MarkLogic Java Client from 8.0-SNAPSHOT to the stable 8.0.0 release.
- Updated logback-classic dependency version to 1.5.19 across embedding model modules
- Upgraded MarkLogic Java Client API from 8.0-SNAPSHOT to stable 8.0.0 release
- Removed obsolete OkHttp shadowing configuration that is no longer needed with Spark 4
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| flux-embedding-model-ollama/build.gradle | Updated logback version and removed OkHttp relocation |
| flux-embedding-model-azure-open-ai/build.gradle | Updated logback version to 1.5.19 |
| flux-cli/build.gradle | Upgraded Java Client API to 8.0.0 and updated related comments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
BillFarber
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some Gradle warnings too. And removed OBE shadowing of okhttp as Spark 4 does not depend on okhttp.