Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jan 6, 2026

Added override for qs, which comes from marklogic.

Added override for qs, which comes from marklogic.
@rjrudin rjrudin requested a review from anu3990 as a code owner January 6, 2026 18:50
Copilot AI review requested due to automatic review settings January 6, 2026 18:50
@rjrudin rjrudin requested a review from BillFarber as a code owner January 6, 2026 18:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates JavaScript dependencies to their latest versions, including langchain, marklogic, and @langchain/openai packages. It also adds an override for the qs package to ensure a specific version is used across the dependency tree.

  • Updated langchain from ^0.3.2 to 1.2.4
  • Updated marklogic from ^3.5.0 to 4.0.0
  • Updated @langchain/openai from ^0.3.0 to 1.2.1
  • Added override for qs package to ^6.14.1
  • Removed @langchain/core dependency
Files not reviewed (1)
  • rag-langchain-js/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"langchain": "^0.3.2",
"marklogic": "^3.5.0"
"langchain": "1.2.4",
"marklogic": "4.0.0"
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies are pinned to exact versions without semver ranges (e.g., ^1.2.4). This prevents automatic patch and minor version updates. Consider using caret (^) or tilde (~) ranges to allow safe updates while maintaining compatibility.

Suggested change
"marklogic": "4.0.0"
"marklogic": "^4.0.0"

Copilot uses AI. Check for mistakes.
},
"devDependencies": {
"@langchain/openai": "^0.3.0"
"@langchain/openai": "1.2.1"
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devDependency is pinned to an exact version without a semver range. Consider using a caret (^) prefix to allow automatic patch and minor version updates for development dependencies.

Suggested change
"@langchain/openai": "1.2.1"
"@langchain/openai": "^1.2.1"

Copilot uses AI. Check for mistakes.
@rjrudin
Copy link
Contributor Author

rjrudin commented Jan 6, 2026

Note the package-lock.json file for this was specifying 0.3.3, which is earlier than the buggy version with a CVE. But this bumps it to the latest patched version.

@rjrudin rjrudin changed the title Bumping JS to latest dependencies MLE-12345 Bumping JS to latest dependencies Jan 6, 2026
@rjrudin rjrudin closed this Jan 6, 2026
@rjrudin rjrudin deleted the feature/bump-js branch January 6, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants