Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jan 6, 2026

Added override for qs, which comes from marklogic.

Added override for qs, which comes from marklogic.
Copilot AI review requested due to automatic review settings January 6, 2026 18:52
@rjrudin
Copy link
Contributor Author

rjrudin commented Jan 6, 2026

Note the package-lock.json file for this was specifying 0.3.3, which is earlier than the buggy version with a CVE. But this bumps it to the latest patched version.

@rjrudin rjrudin merged commit 49d789d into main Jan 6, 2026
1 check passed
@rjrudin rjrudin deleted the feature/bump-js branch January 6, 2026 18:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates JavaScript dependencies to their latest versions and adds an override for the qs package to address a transitive dependency from marklogic.

  • Major version updates to langchain (0.3.2 → 1.2.4) and marklogic (3.5.0 → 4.0.0)
  • Updated @langchain/openai to version 1.2.1
  • Added qs package override to ensure version ^6.14.1 is used
Files not reviewed (1)
  • rag-langchain-js/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +15 to +16
"langchain": "1.2.4",
"marklogic": "4.0.0"
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies are pinned to exact versions (without ^ or ~ prefix). Consider using semantic versioning ranges (e.g., ^1.2.4) to allow automatic patch and minor updates, which is the standard practice for application dependencies.

Copilot uses AI. Check for mistakes.
},
"devDependencies": {
"@langchain/openai": "^0.3.0"
"@langchain/openai": "1.2.1"
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @langchain/openai devDependency is pinned to an exact version without a semver range. For consistency with the stated purpose of updating to 'latest dependencies', consider using ^1.2.1 to allow future patch and minor updates.

Suggested change
"@langchain/openai": "1.2.1"
"@langchain/openai": "^1.2.1"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants