MLE-20430/Support Configure HAProxy At Group Level#100
Merged
Conversation
added 10 commits
August 27, 2025 09:42
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring HAProxy at the group level within MarkLogic clusters, allowing different groups to have distinct HAProxy configurations that can override cluster-level settings.
- Introduces group-level HAProxy configuration through a new
HAProxyGrouptype - Refactors HAProxy configuration generation to support both cluster and group-level settings
- Updates CRD definitions to support the new group-level configuration schema
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/k8sutil/haProxyHelper.go |
Major refactoring of HAProxy configuration logic to support group-level overrides and merge configurations |
pkg/k8sutil/haProxy.go |
Updates to pass context to configuration generation functions and fix typo in annotation key |
config/crd/bases/marklogic.progress.com_marklogicclusters.yaml |
CRD schema updates to add HAProxyGroup configuration and targetPort field |
api/v1/zz_generated.deepcopy.go |
Generated deepcopy methods for new HAProxyGroup type and pointer handling updates |
api/v1/marklogiccluster_types.go |
Type change from HAProxy to HAProxyGroup for group-level configuration |
api/v1/common_types.go |
New HAProxyGroup type definition and TcpPorts field changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rwinieski
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.